From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmgKA-0005PO-RY for qemu-devel@nongnu.org; Thu, 24 Jan 2019 09:49:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmgKA-0008UR-2d for qemu-devel@nongnu.org; Thu, 24 Jan 2019 09:49:46 -0500 References: <20190124144606.4352-1-sourav.jb1988@gmail.com> From: Thomas Huth Message-ID: <0cf9315e-ee03-92e4-a160-de8635d5cb6c@redhat.com> Date: Thu, 24 Jan 2019 15:49:42 +0100 MIME-Version: 1.0 In-Reply-To: <20190124144606.4352-1-sourav.jb1988@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw: edu: set category of the edu device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kumar sourav , qemu-trivial@nongnu.org Cc: jslaby@suse.cz, qemu-devel@nongnu.org On 2019-01-24 15:46, kumar sourav wrote: > Sets the category of edu device as DEVICE_CATEGORY_MISC. > Devices should be assigned to one of DEVICE_CATEGORY_XXXX. > > Signed-off-by: kumar sourav > --- > hw/misc/edu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/misc/edu.c b/hw/misc/edu.c > index ceaf688bfb..91af452c9e 100644 > --- a/hw/misc/edu.c > +++ b/hw/misc/edu.c > @@ -399,6 +399,7 @@ static void edu_instance_init(Object *obj) > > static void edu_class_init(ObjectClass *class, void *data) > { > + DeviceClass *dc = DEVICE_CLASS(class); > PCIDeviceClass *k = PCI_DEVICE_CLASS(class); > > k->realize = pci_edu_realize; > @@ -407,6 +408,7 @@ static void edu_class_init(ObjectClass *class, void *data) > k->device_id = 0x11e8; > k->revision = 0x10; > k->class_id = PCI_CLASS_OTHERS; > + set_bit(DEVICE_CATEGORY_MISC, dc->categories); > } > > static void pci_edu_register_types(void) > Looks fine. Reviewed-by: Thomas Huth