From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH v4 2/3] include: Add a header to define host PCI MMIO functions
Date: Tue, 15 Apr 2025 07:19:44 -0700 [thread overview]
Message-ID: <0d08036b-0b9f-4a8b-8ffc-fa57aec19be7@linaro.org> (raw)
In-Reply-To: <71997461-7470-452b-9df1-3efa6d6f68c4@linaro.org>
On 4/14/25 23:43, Philippe Mathieu-Daudé wrote:
>> +static inline uint8_t host_pci_ldub_p(const void *ioaddr)
>
> Is it really worth inlining?
>
>> +{
>> + uint8_t ret = 0;
>> +#ifdef __s390x__
>> + ret = s390x_pci_mmio_read_8(ioaddr);
>> +#else
>> + ret = ldub_he_p(ioaddr);
>> +#endif
Since the non-s390x path is a single byte load, yes, it probably is worth inlining.
r~
next prev parent reply other threads:[~2025-04-15 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 21:36 [PATCH v4 0/3] Enable QEMU NVMe userspace driver on s390x Farhan Ali
2025-04-14 21:36 ` [PATCH v4 1/3] util: Add functions for s390x mmio read/write Farhan Ali
2025-04-14 21:36 ` [PATCH v4 2/3] include: Add a header to define host PCI MMIO functions Farhan Ali
2025-04-14 22:07 ` Farhan Ali
2025-04-15 6:43 ` Philippe Mathieu-Daudé
2025-04-15 14:19 ` Richard Henderson [this message]
2025-04-15 16:08 ` Farhan Ali
2025-04-14 21:36 ` [PATCH v4 3/3] block/nvme: Use host PCI MMIO API Farhan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d08036b-0b9f-4a8b-8ffc-fa57aec19be7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).