From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18449C46CD4 for ; Thu, 21 Dec 2023 08:10:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGE7I-0001E0-Po; Thu, 21 Dec 2023 03:09:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGE7H-0001Dm-LQ for qemu-devel@nongnu.org; Thu, 21 Dec 2023 03:09:15 -0500 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rGE7F-00042u-Vi for qemu-devel@nongnu.org; Thu, 21 Dec 2023 03:09:15 -0500 Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7b798e6f702so21396839f.2 for ; Thu, 21 Dec 2023 00:09:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1703146152; x=1703750952; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DFHtdbRBuHxh3sdDGxLPtxB6dXV5w1hZThhsj1oHuv8=; b=y7xr+RjCJRdPsepQsgzIxkJEIN6idOdt28G2Fot1mIEzRAgN+uKn14AHCbyu42+FVW lrX9GiHVoeIU3lfgoF571UQwc3Ps+y6SsSD18VF88Jv4kRzcCJua2gFmmKJF9KezfQQ+ l+ukUgJb0QdtgDkUum5QN9/d/d5szK4BXPRVocrb4TInlpFP1+yVF6uLAZBpvFiT5TOr ltTIISERP7Nprjo/UttYd2MWWRZxpZYhtMM8zLMGm6TQX3fLz5f2RZwY+EIJyMNp7NYB OEos4FGDjXiyso0WzR4K+swaIzhqEiw4Vv3HPi2klV3WjmGsRJcbWYd2kjmC6+KXqHwH dQ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703146152; x=1703750952; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DFHtdbRBuHxh3sdDGxLPtxB6dXV5w1hZThhsj1oHuv8=; b=f+Wf5coPASMIqY3JjpbWT2idWMRb5fqyTpvncUy0jD2opskt510ADRucue9lbDgZso 0OfcgvpyvdfjX/glQugaubqfFEtZDhbz4S/LvrFs0JJAqbHa0UbtZCJW04BKDE+ziBkI a6jX1F0ALkVg75GOLIPNTupPTVFVsE6on9IZY4mWYAsBfj7LSmNaDPINdHniAPqQNkPL Mh8y6ayfExklT414KD0sALeWEDZqV8+QDLCfOsxYYaHEQfz/hsVVHHMHzEfA0y+Kmdf8 todHGleT9TLN+2R0f3d8QmdkPR91bXVL3bf+IPW3hMfAODfLIHrw2hg8l53IK06h73eY gsiQ== X-Gm-Message-State: AOJu0YxNjb1ka1XqIET1cSoPdB2FkWp+bd5JnnOTbNNsdjZ62q7lBL/h BsBnsO1YsuCZCXRo4XwE5+mRgA== X-Google-Smtp-Source: AGHT+IH9uE0kFetV0w0R6EKXS4SOYT/kfgC5SWiE3cSPeQAb9GdRshpM1twXSmGc4zg3gIC8XAqDeQ== X-Received: by 2002:a05:6602:24c9:b0:7b7:5eeb:615e with SMTP id h9-20020a05660224c900b007b75eeb615emr19879747ioe.6.1703146152450; Thu, 21 Dec 2023 00:09:12 -0800 (PST) Received: from ?IPV6:2400:4050:a840:1e00:9ac7:6d57:2b16:6932? ([2400:4050:a840:1e00:9ac7:6d57:2b16:6932]) by smtp.gmail.com with ESMTPSA id a25-20020a634d19000000b005c6617b52e6sm1004679pgb.5.2023.12.21.00.09.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 00:09:12 -0800 (PST) Message-ID: <0d08a014-cdf5-4b4f-a683-171ae4c8b6e0@daynix.com> Date: Thu, 21 Dec 2023 17:09:05 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 07/11] virtio-gpu: Handle resource blob commands Content-Language: en-US To: Huang Rui , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann , "Michael S . Tsirkin" , Stefano Stabellini , Anthony PERARD , Antonio Caggiano , "Dr . David Alan Gilbert" , Robert Beckett , Dmitry Osipenko , Gert Wollny , =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, Gurchetan Singh , ernunes@redhat.com, Alyssa Ross , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?Q?Christian_K=C3=B6nig?= , Xenia Ragiadakou , Pierre-Eric Pelloux-Prayer , Honglei Huang , Julia Zhang , Chen Jiqian , Antonio Caggiano References: <20231219075320.165227-1-ray.huang@amd.com> <20231219075320.165227-8-ray.huang@amd.com> From: Akihiko Odaki In-Reply-To: <20231219075320.165227-8-ray.huang@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: none client-ip=2607:f8b0:4864:20::d29; envelope-from=akihiko.odaki@daynix.com; helo=mail-io1-xd29.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2023/12/19 16:53, Huang Rui wrote: > From: Antonio Caggiano > > Support BLOB resources creation, mapping and unmapping by calling the > new stable virglrenderer 0.10 interface. Only enabled when available and > via the blob config. E.g. -device virtio-vga-gl,blob=true I have another concern about delaying virgl_renderer_resource_unref() until the resource gets unmapped; the guest will expect the resource ID will be available for a new resource immediately after VIRTIO_GPU_CMD_RESOURCE_UNREF, but it will break the assumption and may corrupt things.