qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 2/6] qapi/qlist: Add qlist_append_null() macro
Date: Mon, 18 Sep 2017 09:08:48 -0500	[thread overview]
Message-ID: <0d139f3b-a437-03ca-c1b5-91d48d78a920@redhat.com> (raw)
In-Reply-To: <20170916185123.29255-3-mreitz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

On 09/16/2017 01:51 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  include/qapi/qmp/qlist.h | 3 +++
>  1 file changed, 3 insertions(+)

Please update scripts/coccinelle/qobject.cocci to also cover this (since
we updated it for qdict_put_null() in 0f9afc2).

With that addition,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

  reply	other threads:[~2017-09-18 14:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-16 18:51 [Qemu-devel] [PATCH v5 0/6] block: Don't compare strings in bdrv_reopen_prepare() Max Reitz
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 1/6] qapi/qnull: Add own header Max Reitz
2017-09-18 14:05   ` Eric Blake
2017-09-21 11:45   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-10-02 13:13   ` [Qemu-devel] " Markus Armbruster
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 2/6] qapi/qlist: Add qlist_append_null() macro Max Reitz
2017-09-18 14:08   ` Eric Blake [this message]
2017-09-21 11:46   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-10-02 13:13   ` [Qemu-devel] " Markus Armbruster
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 3/6] qapi: Add qobject_is_equal() Max Reitz
2017-09-18 14:15   ` Eric Blake
2017-09-21 12:03   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-10-02 13:13   ` [Qemu-devel] " Markus Armbruster
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 4/6] block: qobject_is_equal() in bdrv_reopen_prepare() Max Reitz
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 5/6] iotests: Add test for non-string option reopening Max Reitz
2017-09-18 14:17   ` Eric Blake
2017-09-16 18:51 ` [Qemu-devel] [PATCH v5 6/6] tests: Add check-qobject for equality tests Max Reitz
2017-09-18 14:25   ` Eric Blake
2017-10-02 13:34   ` Markus Armbruster
2017-10-03 21:19     ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d139f3b-a437-03ca-c1b5-91d48d78a920@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).