Re: [PULL 00/46] Python queue 2020-02-06

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 2/7/20 1:39 PM, Philippe Mathieu-Daudé wrote:
> On 2/7/20 12:51 PM, Peter Maydell wrote:
>> On Thu, 6 Feb 2020 at 21:21, Philippe Mathieu-Daudé 
>> <philmd@redhat.com> wrote:
>>>
>>> Hi Peter,
>>>
>>> I prepared this series on behalf of Eduardo and
>>> Cleber (one of them will ack this cover).
>>>
>>> Regards,
>>>
>>> Phil.
>>>
>>> The following changes since commit 
>>> 418fa86dd465b4fd8394373cf83db8fa65d7611c:
>>>
>>>    Merge remote-tracking branch 
>>> 'remotes/stsquad/tags/pull-testing-040220-1' into staging (2020-02-04 
>>> 18:55:06 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>>    https://gitlab.com/philmd/qemu.git tags/python-next-20200206
>>>
>>> for you to fetch changes up to 3e3481a5df933a26b47f08e5913821672d28d308:
>>>
>>>    .readthedocs.yml: specify some minimum python requirements 
>>> (2020-02-06 21:48:24 +0100)
>>
>> Hi; this fails 'make check' (all hosts):
>>
>>    TEST    iotest-qcow2: 252
>>    TEST    iotest-qcow2: 256
>>    TEST    iotest-qcow2: 265
>>    TEST    iotest-qcow2: 267
>>    TEST    iotest-qcow2: 268
>>    TEST    iotest-qcow2: 283 [fail]
>> QEMU          --
>> "/home/petmay01/linaro/qemu-for-merges/build/all/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" 
>>
>> -nodefaults -display none -accel qtest
>> QEMU_IMG      --
>> "/home/petmay01/linaro/qemu-for-merges/build/all/tests/qemu-iotests/../../qemu-img" 
>>
>> QEMU_IO       --
>> "/home/petmay01/linaro/qemu-for-merges/build/all/tests/qemu-iotests/../../qemu-io" 
>>
>>   --cache writeback --aio threads -f qcow2
>> QEMU_NBD      --
>> "/home/petmay01/linaro/qemu-for-merges/build/all/tests/qemu-iotests/../../qemu-nbd" 
>>
>> IMGFMT        -- qcow2 (compat=1.1)
>> IMGPROTO      -- file
>> PLATFORM      -- Linux/x86_64 e104462 4.15.0-74-generic
>> TEST_DIR      --
>> /home/petmay01/linaro/qemu-for-merges/build/all/tests/qemu-iotests/scratch 
>>
>> SOCK_DIR      -- /tmp/tmp.oppAzNNHIY
>> SOCKET_SCM_HELPER --
>> /home/petmay01/linaro/qemu-for-merges/build/all/tests/qemu-iotests/socket_scm_helper 
>>
>>
>> --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/283.out
>>   2020-02-06 18:59:06.291529139 +0000
>> +++ 
>> /home/petmay01/linaro/qemu-for-merges/build/all/tests/qemu-iotests/283.out.bad 
>>
>>       2020-02-07 11:25:38.477373907 +0000
>> @@ -1,8 +1 @@
>> -{"execute": "blockdev-add", "arguments": {"driver": "null-co",
>> "node-name": "target"}}
>> -{"return": {}}
>> -{"execute": "blockdev-add", "arguments": {"driver": "blkdebug",
>> "image": {"driver": "null-co", "node-name": "base", "size": 1048576},
>> "node-name": "source"}}
>> -{"return": {}}
>> -{"execute": "blockdev-add", "arguments": {"driver": "blkdebug",
>> "image": "base", "node-name": "other", "take-child-perms": ["write"]}}
>> -{"return": {}}
>> -{"execute": "blockdev-backup", "arguments": {"device": "source",
>> "sync": "full", "target": "target"}}
>> -{"error": {"class": "GenericError", "desc": "Cannot set permissions
>> for backup-top filter: Conflicts with use by other as 'image', which
>> uses 'write' on base"}}
>> +./check: line 866: ./283: Permission denied
>> Not run: 220
>> Failures: 283
> 
> Interesting.
> I apologize this test is not in my suite.

Actually test 283 was merged yesterday few hours before I send this pull 
request (which is why it passed the new checkpatch test), and it doesn't 
use the Python 3 interpreter after shebang.

Once updated to Python 3, with this hunk, the test pass:

-- >8 --
--- a/tests/qemu-iotests/283
+++ b/tests/qemu-iotests/283
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
  #
  # Test for backup-top filter permission activation failure
  #
---

   ...
   TEST    iotest-qcow2: 244
   TEST    iotest-qcow2: 249
   TEST    iotest-qcow2: 251
   TEST    iotest-qcow2: 252
   TEST    iotest-qcow2: 256
   TEST    iotest-qcow2: 265
   TEST    iotest-qcow2: 267
   TEST    iotest-qcow2: 268
   TEST    iotest-qcow2: 283
Not run: 220
Passed all 115 iotests

I'll rebase and respin.

> 
>> Failed 1 of 115 iotests
>> /home/petmay01/linaro/qemu-for-merges/tests/Makefile.include:842:
>> recipe for target 'check-tests/check-block.sh' failed