From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D2CC12002 for ; Fri, 16 Jul 2021 21:58:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72D89613E3 for ; Fri, 16 Jul 2021 21:58:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72D89613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4Vqi-00078b-MZ for qemu-devel@archiver.kernel.org; Fri, 16 Jul 2021 17:58:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4Vo3-0004X3-IE for qemu-devel@nongnu.org; Fri, 16 Jul 2021 17:55:39 -0400 Received: from mga04.intel.com ([192.55.52.120]:18286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4Vo1-0000Tw-BL for qemu-devel@nongnu.org; Fri, 16 Jul 2021 17:55:39 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10047"; a="208978653" X-IronPort-AV: E=Sophos;i="5.84,246,1620716400"; d="scan'208";a="208978653" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 14:55:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,246,1620716400"; d="scan'208";a="563257996" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 16 Jul 2021 14:55:31 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 16 Jul 2021 14:55:31 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 16 Jul 2021 14:55:30 -0700 Received: from orsmsx611.amr.corp.intel.com ([10.22.229.24]) by ORSMSX611.amr.corp.intel.com ([10.22.229.24]) with mapi id 15.01.2242.010; Fri, 16 Jul 2021 14:55:30 -0700 From: "Kasireddy, Vivek" To: "Kim, Dongwon" , "qemu-devel@nongnu.org" Subject: RE: [PATCH 3/3] ui/gtk: gd_draw_event returns FALSE when no cairo surface is bound Thread-Topic: [PATCH 3/3] ui/gtk: gd_draw_event returns FALSE when no cairo surface is bound Thread-Index: AQHXb6K0XNEQkcVAhEqpMJSIxAXmqKtGOztA Date: Fri, 16 Jul 2021 21:55:30 +0000 Message-ID: <0d19e5d7c90e4865bb23d10020db6ac2@intel.com> References: <20210703002809.26753-1-dongwon.kim@intel.com> <20210703002809.26753-3-dongwon.kim@intel.com> In-Reply-To: <20210703002809.26753-3-dongwon.kim@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received-SPF: pass client-ip=192.55.52.120; envelope-from=vivek.kasireddy@intel.com; helo=mga04.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Kim, Dongwon" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Vivek Kasireddy > -----Original Message----- > From: Qemu-devel On > Behalf Of Dongwon Kim > Sent: Friday, July 02, 2021 5:28 PM > To: qemu-devel@nongnu.org > Cc: Kim, Dongwon > Subject: [PATCH 3/3] ui/gtk: gd_draw_event returns FALSE when no cairo su= rface is > bound >=20 > gd_draw_event shouldn't try to repaint if surface does not exist > for the VC. >=20 > Signed-off-by: Dongwon Kim > --- > ui/gtk.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/ui/gtk.c b/ui/gtk.c > index bfb95f3b4b..0a38deedc7 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -756,6 +756,9 @@ static gboolean gd_draw_event(GtkWidget *widget, cair= o_t *cr, > void *opaque) > if (!vc->gfx.ds) { > return FALSE; > } > + if (!vc->gfx.surface) { > + return FALSE; > + } >=20 > vc->gfx.dcl.update_interval =3D > gd_monitor_update_interval(vc->window ? vc->window : s->window); > -- > 2.17.1 >=20