* [PATCH] qga/commands-posix: fix typo in qmp_guest_set_user_password
@ 2024-05-03 17:13 Paolo Bonzini
2024-05-03 17:25 ` Thomas Huth
2024-05-03 18:00 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2024-05-03 17:13 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, kkostiuk
qga/commands-posix.c does not compile on FreeBSD due to a confusion
between "chpasswdata" (wrong) and "chpasswddata" (used in the #else
branch).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
qga/commands-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 7a065c4085c..7f05996495a 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2173,7 +2173,7 @@ void qmp_guest_set_user_password(const char *username,
}
#ifdef __FreeBSD__
- g_autofree char *chpasswdata = g_strdup(rawpasswddata);
+ g_autofree char *chpasswddata = g_strdup(rawpasswddata);
const char *crypt_flag = crypted ? "-H" : "-h";
const char *argv[] = {"pw", "usermod", "-n", username,
crypt_flag, "0", NULL};
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qga/commands-posix: fix typo in qmp_guest_set_user_password
2024-05-03 17:13 [PATCH] qga/commands-posix: fix typo in qmp_guest_set_user_password Paolo Bonzini
@ 2024-05-03 17:25 ` Thomas Huth
2024-05-03 18:00 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2024-05-03 17:25 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: kkostiuk, QEMU Trivial, Andrey Drobyshev
On 03/05/2024 19.13, Paolo Bonzini wrote:
> qga/commands-posix.c does not compile on FreeBSD due to a confusion
> between "chpasswdata" (wrong) and "chpasswddata" (used in the #else
> branch).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> qga/commands-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 7a065c4085c..7f05996495a 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -2173,7 +2173,7 @@ void qmp_guest_set_user_password(const char *username,
> }
>
> #ifdef __FreeBSD__
> - g_autofree char *chpasswdata = g_strdup(rawpasswddata);
> + g_autofree char *chpasswddata = g_strdup(rawpasswddata);
> const char *crypt_flag = crypted ? "-H" : "-h";
> const char *argv[] = {"pw", "usermod", "-n", username,
> crypt_flag, "0", NULL};
Fixes: 0e5b75a390 ("qga/commands-posix: qmp_guest_set_user_password: use
ga_run_command helper")
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qga/commands-posix: fix typo in qmp_guest_set_user_password
2024-05-03 17:13 [PATCH] qga/commands-posix: fix typo in qmp_guest_set_user_password Paolo Bonzini
2024-05-03 17:25 ` Thomas Huth
@ 2024-05-03 18:00 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-05-03 18:00 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: thuth, kkostiuk
On 3/5/24 19:13, Paolo Bonzini wrote:
> qga/commands-posix.c does not compile on FreeBSD due to a confusion
> between "chpasswdata" (wrong) and "chpasswddata" (used in the #else
> branch).
>
Fixes: 0e5b75a390 ("qga/commands-posix: qmp_guest_set_user_password: use
ga_run_command helper")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> qga/commands-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-03 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-03 17:13 [PATCH] qga/commands-posix: fix typo in qmp_guest_set_user_password Paolo Bonzini
2024-05-03 17:25 ` Thomas Huth
2024-05-03 18:00 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).