From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Richard W.M. Jones" <rjones@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 09/12] Makefile, configure: Support building rST documentation
Date: Mon, 1 Apr 2019 07:51:18 -0500 [thread overview]
Message-ID: <0d2c48da-dba9-6a8e-eca4-41fbd3c317b2@redhat.com> (raw)
In-Reply-To: <CAFEAcA8U1o7JZmAP4nhsiY+riFtZmxHBQCkOu0zmR++K70gnQA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]
On 4/1/19 2:58 AM, Peter Maydell wrote:
> On Sat, 30 Mar 2019 at 22:05, Eric Blake <eblake@redhat.com> wrote:
>> Rich told me that qemu-nbd.8 was not being built, and I confirmed that
>> it failed to build for me. git bisect points to this commit as the
>> reason that 'touch qemu-nbd.texi; make' no longer rebuilds qemu-nbd.8
>> automatically. Is it merely because I don't have enough stuff installed,
>> or is it an actual broken dependency?
>>
>> /me goes and runs 'dnf install "*/sphinx-build"...
>>
>> Nope, even with that installed, qemu-nbd.8 is still not getting built by
>> 'make'; but 'make qemu-nbd.8' is working. We lost a dependency :(
>
> I just did a test build from clean and I get a qemu-nbd.8 in the
> build directory. I also checked that 'touch qemu-nbd.texi; make -C build V=1'
> rebuilds the manpage, and it does:
>
> [snip other stuff]
> perl -Ww -- /home/pm215/qemu/scripts/texi2pod.pl -I docs -I
> /home/pm215/qemu -I . "-DVERSION=3.1.91"
> /home/pm215/qemu/qemu-nbd.texi qemu-nbd.8.pod && pod2man --utf8
> --section=8 --center=" " --release=" " qemu-nbd.8.pod > qemu-nbd.8
> [...]
>
> You will need sphinx-build in order to build
> the docs now, and without that we won't build the manpage, but
> if you have sphinx-build installed then it should work.
> Can you check that your config-host.mak has BUILD_DOCS=yes ?
Not seeing it.
> Did you definitely rerun configure after installing sphinx?
Trying that again. I did not specify anything special to configure to
force-enable/disable docs, so this time, it should auto-detect that
sphinx-build is present...
and now BUILD_DOCS=yes appears...
And that fixes it. Thanks for helping me spot the added build dependency.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-04-01 12:51 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 17:21 [Qemu-devel] [PATCH v3 00/12] Enable build and install of our rST docs Peter Maydell
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 01/12] docs/cpu-hotplug.rst: Fix rST markup issues Peter Maydell
2019-03-05 22:34 ` Richard Henderson
2019-03-07 0:04 ` Cleber Rosa
2019-03-07 9:47 ` Peter Maydell
2019-03-07 11:15 ` Cleber Rosa
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 02/12] docs: Convert memory.txt to rst format Peter Maydell
2019-03-05 22:40 ` Richard Henderson
2019-03-07 0:11 ` Cleber Rosa
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 03/12] docs: Commit initial files from sphinx-quickstart Peter Maydell
2019-03-05 22:36 ` Richard Henderson
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 04/12] docs/conf.py: Disable unused _static directory Peter Maydell
2019-03-05 22:36 ` Richard Henderson
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 05/12] docs/conf.py: Configure the 'alabaster' theme Peter Maydell
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 06/12] docs/conf.py: Don't include rST sources in HTML build Peter Maydell
2019-03-05 22:42 ` Richard Henderson
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 07/12] docs/conf.py: Disable option warnings Peter Maydell
2019-03-05 22:42 ` Richard Henderson
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 08/12] docs: Provide separate conf.py for each manual we want Peter Maydell
2019-03-07 1:40 ` Cleber Rosa
2019-03-07 9:49 ` Peter Maydell
2019-03-07 12:14 ` Cleber Rosa
2019-03-07 12:29 ` Peter Maydell
2019-03-07 13:18 ` Cleber Rosa
2019-03-07 13:30 ` Peter Maydell
2019-03-07 13:41 ` Cleber Rosa
2019-03-07 13:46 ` Peter Maydell
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 09/12] Makefile, configure: Support building rST documentation Peter Maydell
2019-03-05 22:45 ` Richard Henderson
[not found] ` <92ffba93-e486-647a-01ef-86180fb2cbb2@redhat.com>
2019-04-01 7:58 ` Peter Maydell
2019-04-01 12:51 ` Eric Blake [this message]
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 10/12] Makefile: Abstract out "identify the pkgversion" code Peter Maydell
2019-03-05 22:33 ` Richard Henderson
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 11/12] docs/conf.py: Don't hard-code QEMU version Peter Maydell
2019-03-05 22:46 ` Richard Henderson
2019-03-05 17:21 ` [Qemu-devel] [PATCH v3 12/12] MAINTAINERS: Add entry for Sphinx documentation infrastructure Peter Maydell
2019-03-05 18:08 ` Philippe Mathieu-Daudé
2019-03-05 22:47 ` Richard Henderson
2019-03-05 17:44 ` [Qemu-devel] [PATCH v3 00/12] Enable build and install of our rST docs no-reply
2019-03-05 18:17 ` no-reply
2019-03-06 1:28 ` no-reply
2019-03-06 1:32 ` no-reply
2019-03-07 0:10 ` no-reply
2019-03-07 0:15 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d2c48da-dba9-6a8e-eca4-41fbd3c317b2@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).