qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Like Xu <like.xu@linux.intel.com>
To: Zhanghailiang <zhang.zhanghailiang@huawei.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/2] migration/colo: fix typo in the COLO Framework module
Date: Mon, 15 Jun 2020 10:23:54 +0800	[thread overview]
Message-ID: <0d30a6ce-6641-dc82-10e5-cd748dbf104a@linux.intel.com> (raw)
In-Reply-To: <17a0016f32fb471fa57e4f0c21ecb19d@huawei.com>

On 2020/6/15 9:36, Zhanghailiang wrote:
> Hi Like,
> 
> Please check this patch, It seems that you didn't use git format-patch command to generate this patch,
> It is in wrong format.

I rebase the patch on the top commit of
7d3660e79830a069f1848bb4fa1cdf8f666424fb,
and hope it helps you.

> 
> Thanks,
> Hailiang

 From 15c19be9be07598d4264a4a84b85d4efa79bff9d Mon Sep 17 00:00:00 2001
From: Like Xu <like.xu@linux.intel.com>
Date: Mon, 15 Jun 2020 10:10:57 +0800
Subject: [PATCH 1/2] migration/colo: fix typo in the COLO Framework module

Cc: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
---
  docs/COLO-FT.txt | 8 ++++----
  migration/colo.c | 2 +-
  2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt
index c8e1740935..fdc0207cff 100644
--- a/docs/COLO-FT.txt
+++ b/docs/COLO-FT.txt
@@ -10,7 +10,7 @@ See the COPYING file in the top-level directory.
  This document gives an overview of COLO's design and how to use it.

  == Background ==
-Virtual machine (VM) replication is a well known technique for providing
+Virtual machine (VM) replication is a well-known technique for providing
  application-agnostic software-implemented hardware fault tolerance,
  also known as "non-stop service".

@@ -103,7 +103,7 @@ Primary side.

  COLO Proxy:
  Delivers packets to Primary and Secondary, and then compare the responses 
from
-both side. Then decide whether to start a checkpoint according to some rules.
+both sides. Then decide whether to start a checkpoint according to some rules.
  Please refer to docs/colo-proxy.txt for more information.

  Note:
@@ -146,12 +146,12 @@ in test procedure.

  == Test procedure ==
  Note: Here we are running both instances on the same host for testing,
-change the IP Addresses if you want to run it on two hosts. Initally
+change the IP Addresses if you want to run it on two hosts. Initially
  127.0.0.1 is the Primary Host and 127.0.0.2 is the Secondary Host.

  == Startup qemu ==
  1. Primary:
-Note: Initally, $imagefolder/primary.qcow2 needs to be copied to all hosts.
+Note: Initially, $imagefolder/primary.qcow2 needs to be copied to all hosts.
  You don't need to change any IP's here, because 0.0.0.0 listens on any
  interface. The chardev's with 127.0.0.1 IP's loopback to the local qemu
  instance.
diff --git a/migration/colo.c b/migration/colo.c
index ea7d1e9d4e..80788d46b5 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -632,7 +632,7 @@ out:
      /*
       * It is safe to unregister notifier after failover finished.
       * Besides, colo_delay_timer and colo_checkpoint_sem can't be
-     * released befor unregister notifier, or there will be use-after-free
+     * released before unregister notifier, or there will be use-after-free
       * error.
       */
      colo_compare_unregister_notifier(&packets_compare_notifier);
-- 
2.21.3




  reply	other threads:[~2020-06-15  2:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14  8:45 [PATCH 1/2] migration/colo: fix typo in the COLO Framework module Like Xu
2020-06-14  8:45 ` [PATCH 2/2] migration/colo/net: fix typo in the COLO Proxy module Like Xu
2020-06-15  5:49   ` Zhang, Chen
2020-06-15  1:36 ` [PATCH 1/2] migration/colo: fix typo in the COLO Framework module Zhanghailiang
2020-06-15  2:23   ` Like Xu [this message]
2020-06-15  3:05     ` Zhanghailiang
2020-06-15  4:29       ` Zhang, Chen
2020-06-15  8:48 ` Zhanghailiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d30a6ce-6641-dc82-10e5-cd748dbf104a@linux.intel.com \
    --to=like.xu@linux.intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).