From: Richard Henderson <richard.henderson@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: philmd@linaro.org, ale@rev.ng, anjo@rev.ng, bcain@quicinc.com,
quic_mathbern@quicinc.com
Subject: Re: [PATCH 07/21] Hexagon (target/hexagon) Eliminate uses of log_pred_write function
Date: Wed, 26 Apr 2023 22:18:58 +0100 [thread overview]
Message-ID: <0d357dfd-79a7-a343-9cb8-80328bd76060@linaro.org> (raw)
In-Reply-To: <20230426004154.1319172-1-tsimpson@quicinc.com>
On 4/26/23 01:41, Taylor Simpson wrote:
> These instructions have implicit writes to registers, so we don't
> want them to be helpers when idef-parser is off.
>
> The following instructions are overriden
> S2_cabacdecbin
> SA1_cmpeqi
>
> Remove the log_pred_write function from op_helper.c
> Remove references in macros.h
>
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
> target/hexagon/gen_tcg.h | 16 +++++++
> target/hexagon/helper.h | 2 +
> target/hexagon/macros.h | 4 --
> target/hexagon/genptr.c | 5 ++
> target/hexagon/op_helper.c | 96 ++++++++++++++++++++++++++++++++------
> 5 files changed, 104 insertions(+), 19 deletions(-)
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2023-04-26 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 0:41 [PATCH 07/21] Hexagon (target/hexagon) Eliminate uses of log_pred_write function Taylor Simpson
2023-04-26 21:18 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d357dfd-79a7-a343-9cb8-80328bd76060@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).