From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Dov Murik" <dovmurik@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH] checkpatch: Detect '%#' or '%0#' in printf-style format strings
Date: Tue, 22 Sep 2020 11:22:16 +0200 [thread overview]
Message-ID: <0d3d01a5-6c3b-7c0f-adce-cc0c452744a0@redhat.com> (raw)
In-Reply-To: <83728898-f305-d6df-f4ed-63580ff87eab@redhat.com>
On 14/09/20 15:00, Philippe Mathieu-Daudé wrote:
>> That makes sense, except that 'last' statement which will escape the
>> loop if one of the bad patterns is found.
>>
>> Maybe we can just drop 'last' from both if-then blocks? We'll get
>> multiple alerts if bad patterns are used more than once in the same
>> line, which sounds OK to me.
> No objection.
>
Sounds good.
Paolo
prev parent reply other threads:[~2020-09-22 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 6:01 [PATCH] checkpatch: Detect '%#' or '%0#' in printf-style format strings Dov Murik
2020-09-14 6:55 ` Philippe Mathieu-Daudé
2020-09-14 11:27 ` Dov Murik
2020-09-14 13:00 ` Philippe Mathieu-Daudé
2020-09-22 9:22 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d3d01a5-6c3b-7c0f-adce-cc0c452744a0@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=dovmurik@linux.vnet.ibm.com \
--cc=eblake@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).