From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dmitry Fomichev" <Dmitry.Fomichev@wdc.com>,
"Maxim Levitsky" <mlevitsk@redhat.com>,
"Max Reitz" <mreitz@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Subject: Re: [PATCH 1/2] file-posix: Correctly read max_segments of SG nodes
Date: Sat, 19 Sep 2020 17:18:08 +0200 [thread overview]
Message-ID: <0d5dbf40-133e-4dd8-de03-ec8744cb90c6@redhat.com> (raw)
In-Reply-To: <MN2PR04MB5951128F548F519AC0E5B9A1E13E0@MN2PR04MB5951.namprd04.prod.outlook.com>
On 17/09/20 18:44, Dmitry Fomichev wrote:
>
> Maxim, looks like you are on top of this problem and your approach sounds
> sensible too me. Just FYI, it is also possible to avoid using SG_GET_SG_TABLESIZE
> ioctl and rely entirely on sysfs, but the code gets a bit more complicated (see below)
I would prefer to have the code in block/ but I have no problem if the
hardware limits are placed in a new field of bs->bl. Then scsi-block
and scsi-generic can consult it instead of bs->bl.max_transfer.
Paolo
next prev parent reply other threads:[~2020-09-19 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 22:51 [PATCH 0/2] block;scsi-generic: Fix max transfer size calculation Dmitry Fomichev
2020-08-11 22:51 ` [PATCH 1/2] file-posix: Correctly read max_segments of SG nodes Dmitry Fomichev
2020-09-17 13:16 ` Max Reitz
2020-09-17 13:22 ` Maxim Levitsky
2020-09-17 13:24 ` Maxim Levitsky
2020-09-17 16:44 ` Dmitry Fomichev
2020-09-19 15:18 ` Paolo Bonzini [this message]
2020-09-19 15:15 ` Paolo Bonzini
2020-08-11 22:51 ` [PATCH 2/2] scsi-generic: Fix HM-zoned device scan Dmitry Fomichev
2020-08-17 15:58 ` Alistair Francis
2020-08-17 16:38 ` [PATCH 0/2] block; scsi-generic: Fix max transfer size calculation Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d5dbf40-133e-4dd8-de03-ec8744cb90c6@redhat.com \
--to=pbonzini@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Dmitry.Fomichev@wdc.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).