From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ACF2E7716F for ; Wed, 4 Dec 2024 23:38:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIywC-0003gA-Hw; Wed, 04 Dec 2024 18:37:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIywB-0003ex-4z for qemu-devel@nongnu.org; Wed, 04 Dec 2024 18:37:43 -0500 Received: from mail-oa1-x30.google.com ([2001:4860:4864:20::30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIyw8-00011P-8I for qemu-devel@nongnu.org; Wed, 04 Dec 2024 18:37:42 -0500 Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-29e585968a8so288816fac.3 for ; Wed, 04 Dec 2024 15:37:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733355459; x=1733960259; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wm+YprTKZReL/LK+leQhteNkdpgiYwW0BQBegMkxYto=; b=EHWHKM8z3MGn8nfIBkvXtwaGyUaq4YnbkbVBYr+y4YlM7EUDo/m7R/tZUcrON73tT0 2F9GcyBR5XV1L5LogHZTpEktrqaG32FteyWx+6HIwfoMrWI2bpa4cD7OhD/ZinC2mjDW 5W0ltVBs3yGO/pw7tR6kS8ub7s2L2VLqk2VZldwZjLYKq9+LoQi87emY7+LxklJ+DqLR 2ziEzqcEs22bl9lZ243XQUtzBJHnDST9dGYB3AYwx4+Um1jFLf/Ru5LlO6LE1s8UlCEO dAuSEfWzcpRGiAe1AgC8p86VH9Odh4lSWsk/l7zxvplMYZX4oCsq/osoz8VPUat/kscM 4VZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733355459; x=1733960259; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wm+YprTKZReL/LK+leQhteNkdpgiYwW0BQBegMkxYto=; b=oE9V3n2wXZzmyHR3V2gAt/7+8KFgCGQHjND6ibEVEcG+pFsOK5sU0s8mB1eEHRS3Up RH6dspR59n8h4bF0zdxfKqSoo65BGUyLxsAD4LViFP1eQUna4f7WhP4aOFQUVDVgZvEt WrjEn4kAqEC6z6DXbDau/Hvl6SOg7jMQPBYsb/tmPgfSM1saKM5jfngUP/PrircRf8sI ZaGpGHxKsu7bKolDZfKhpbucbeJ6LiPNzmtBFq2kvWL38X3oED6XjyMeYGq5HzrIEO3c 6Gb3EXeJ2iS2ALq02FTlglse9/NEJrdVsHrz0CBUH9HHbmOeOeNYmRWGgA8ynTlExRNc LWkQ== X-Forwarded-Encrypted: i=1; AJvYcCXyE8ZFeM9Faw97YNYCeNj4qmR2u//o1nfue/97Ze+0cppEafeLskANIfVZddrxwz7Csbqw8l2z5PKR@nongnu.org X-Gm-Message-State: AOJu0YxwCAJ5TyCybwgSFLBkYA89ftDabpAdJCa1yMc9eS7L+XY+hder gsdX4hkTsSB9R/sDFORXsGHQLGNDYJV+XbtDvj74A7Bw+2Cy+Ac6dAelNFVi/1k= X-Gm-Gg: ASbGncsgbVXgrne/ah+/ceHZlJ3g1JwokhL5XF6IXInqhk9Jt9UGx/TQJrwz89dofSq rSQ9nQrftEpcYgV4jqAxvW/X7tguf+mr/9a+3ofthFD04R4sM/1SXvmisMsYJ4QVq9GGAHA/o7Z UA6LZuVrLjYMGNVinHtM7VnN0+UE72mDR10wCDsJadPTiXSKxMcsTVHTtDp6oSiySKq3rYK6dlj RcFUiD4UiiIgb3aodn3BgaqyfWUcijI+LspQtHzs2RvRpUAcryokCxnQvzl0dkDpKSkDDDIzIAm R+Te0Zrh7EcO76Vmm0DkSLP0YP3k X-Google-Smtp-Source: AGHT+IGQsmUAz55PbS5EOvlhoU2E/aJNx/BDCXWj4pV0epb2rOhhk8aiNJjl0hBDH+VvoB2qFITnFw== X-Received: by 2002:a05:6871:80f:b0:29e:526a:eeef with SMTP id 586e51a60fabf-29e88853236mr7884885fac.34.1733355458928; Wed, 04 Dec 2024 15:37:38 -0800 (PST) Received: from [192.168.4.112] (fixed-187-189-51-143.totalplay.net. [187.189.51.143]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-29f569a698dsm64079fac.49.2024.12.04.15.37.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 15:37:38 -0800 (PST) Message-ID: <0d698119-9ea0-4499-96ce-6a194d305c52@linaro.org> Date: Wed, 4 Dec 2024 17:37:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/20] target/arm: Implement CPUClass::datapath_is_big_endian To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , "Michael S. Tsirkin" , Peter Maydell , Laurent Vivier , Mark Cave-Ayland , Alistair Francis , Anton Johansson , Zhao Liu , "Edgar E. Iglesias" , David Hildenbrand , qemu-s390x@nongnu.org, Max Filippov , Paolo Bonzini , Nicholas Piggin , qemu-arm@nongnu.org, Thomas Huth , qemu-riscv@nongnu.org, Alistair Francis , qemu-ppc@nongnu.org References: <20241204202602.58083-1-philmd@linaro.org> <20241204202602.58083-4-philmd@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: <20241204202602.58083-4-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:4860:4864:20::30; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/4/24 14:25, Philippe Mathieu-Daudé wrote: > arm_cpu_virtio_is_big_endian() already returns whether > the data path is in big endian. Re-use that. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) No, this is wrong. (1) arm_cpu_virtio_is_big_endian really *is* specific to virtio, and legacy virtio at that. It changes based on the state of the cpu. (2) The board-level stuff for which you appear to be intending to replace qemu_binary_is_bigendian(), for arm, is *always* little-endian, and has no relation to the state of the cpu. (3) I thought you were on a better track plumbing endianness through properties on machine state. r~ > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index 6938161b954..3061b2ac18c 100644 > --- a/target/arm/cpu.c > +++ b/target/arm/cpu.c > @@ -1132,7 +1132,7 @@ static void arm_cpu_kvm_set_irq(void *opaque, int irq, int level) > #endif > } > > -static bool arm_cpu_virtio_is_big_endian(CPUState *cs) > +static bool arm_cpu_datapath_is_big_endian(CPUState *cs) > { > ARMCPU *cpu = ARM_CPU(cs); > CPUARMState *env = &cpu->env; > @@ -2664,7 +2664,7 @@ static const struct SysemuCPUOps arm_sysemu_ops = { > .asidx_from_attrs = arm_asidx_from_attrs, > .write_elf32_note = arm_cpu_write_elf32_note, > .write_elf64_note = arm_cpu_write_elf64_note, > - .virtio_is_big_endian = arm_cpu_virtio_is_big_endian, > + .virtio_is_big_endian = arm_cpu_datapath_is_big_endian, > .legacy_vmsd = &vmstate_arm_cpu, > }; > #endif > @@ -2709,6 +2709,7 @@ static void arm_cpu_class_init(ObjectClass *oc, void *data) > &acc->parent_phases); > > cc->class_by_name = arm_cpu_class_by_name; > + cc->datapath_is_big_endian = arm_cpu_datapath_is_big_endian; > cc->has_work = arm_cpu_has_work; > cc->mmu_index = arm_cpu_mmu_index; > cc->dump_state = arm_cpu_dump_state;