From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Miroslav Rezanina <mrezanin@redhat.com>,
qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, pbonzini@redhat.com
Subject: Re: [PATCH] Fix libdaxctl option
Date: Wed, 7 Jul 2021 10:13:31 +0200 [thread overview]
Message-ID: <0d76b55d-3c13-c0d1-4aea-49eab97d839b@redhat.com> (raw)
In-Reply-To: <66a2e508-462b-a19f-3d04-1a55077aba89@redhat.com>
On 7/7/21 8:35 AM, Thomas Huth wrote:
> On 07/07/2021 08.31, Miroslav Rezanina wrote:
>> For some reason, libdaxctl option setting was set to work in an opposite
>> way (--enable-libdaxctl disabled it and vice versa). Fixing this so
>> configuration works properly.
>>
>> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
>> ---
>> configure | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 650d9c0735..4f51528a77 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1531,9 +1531,9 @@ for opt do
>> ;;
>> --disable-keyring) secret_keyring="no"
>> ;;
>> - --enable-libdaxctl) libdaxctl=disabled
>> + --enable-libdaxctl) libdaxctl="enabled"
>> ;;
>> - --disable-libdaxctl) libdaxctl=enabled
>> + --disable-libdaxctl) libdaxctl="disabled"
>> ;;
>> --enable-fuse) fuse="enabled"
>> ;;
>>
>
> Fixes: 83ef16821a ("configure, meson: convert libdaxctl detection to
> meson")
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2021-07-07 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 6:31 [PATCH] Fix libdaxctl option Miroslav Rezanina
2021-07-07 6:35 ` Thomas Huth
2021-07-07 8:13 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d76b55d-3c13-c0d1-4aea-49eab97d839b@redhat.com \
--to=philmd@redhat.com \
--cc=mrezanin@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).