From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Greg Kurz" <groug@kaod.org>,
"Vaibhav Jain" <vaibhav@linux.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
david@gibson.dropbear.id.au, clg@kaod.org,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Kowshik Jois B S <kowsjois@linux.ibm.com>
Subject: Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'
Date: Thu, 17 Nov 2022 09:24:45 +0100 [thread overview]
Message-ID: <0d802e96-6ce4-442d-779c-7c29eef5caab@redhat.com> (raw)
In-Reply-To: <51b78663-2b5c-2599-da04-a0a18e8315b8@linaro.org>
On 16/11/2022 16.30, Philippe Mathieu-Daudé wrote:
> On 16/11/22 16:20, Greg Kurz wrote:
>> Hi Vaibhav,
>>
>> Nice to see some people are still building QEMU at IBM ;-)
>>
>> On Wed, 16 Nov 2022 18:47:43 +0530
>> Vaibhav Jain <vaibhav@linux.ibm.com> wrote:
>>
>>> Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
>>> target is failing due to following build warnings:
>>>
>>> <snip>
>>> ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc'
>>> defined but not used [-Werror=unused-function]
>>> 7018 | static void ppc_restore_state_to_opc(CPUState *cs,
>>> <snip>
>>>
>>> Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so
>>> that
>>> they are only defined if qemu is compiled with '--enable-tcg'
>
> Interestingly this config isn't covered in
> .gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml.
Why should it be tested there? s390x is not ppc64.
If you want to test this, you either have to do it with a cross compiler (in
.gitlab-ci.d/crossbuilds.yml) or in .travis.yml on a ppc64 host.
Thomas
next prev parent reply other threads:[~2022-11-17 8:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 13:17 [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg' Vaibhav Jain
2022-11-16 15:20 ` Greg Kurz
2022-11-16 15:30 ` Philippe Mathieu-Daudé
2022-11-17 8:24 ` Thomas Huth [this message]
2022-11-17 2:13 ` Vaibhav Jain
2022-11-17 6:49 ` Cédric Le Goater
2022-11-16 15:27 ` [PATCH-for-7.2] " Philippe Mathieu-Daudé
2022-11-17 2:23 ` Vaibhav Jain
2022-11-17 7:34 ` [PATCH] " Kowshik Jois B S
2022-11-17 10:11 ` Daniel Henrique Barboza
2022-11-17 10:35 ` Vaibhav Jain
2022-11-17 14:23 ` Daniel Henrique Barboza
2022-11-17 10:50 ` Greg Kurz
2022-11-17 13:08 ` Cédric Le Goater
2022-11-17 14:27 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d802e96-6ce4-442d-779c-7c29eef5caab@redhat.com \
--to=thuth@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=kowsjois@linux.ibm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).