From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26D7CC43334 for ; Mon, 20 Jun 2022 19:03:59 +0000 (UTC) Received: from localhost ([::1]:58670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3Mgo-0002FV-2w for qemu-devel@archiver.kernel.org; Mon, 20 Jun 2022 15:03:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3M8A-0002aV-3e for qemu-devel@nongnu.org; Mon, 20 Jun 2022 14:28:10 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:38221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3M87-0007BV-Bt for qemu-devel@nongnu.org; Mon, 20 Jun 2022 14:28:09 -0400 Received: by mail-pj1-x102f.google.com with SMTP id p3-20020a17090a428300b001ec865eb4a2so6386653pjg.3 for ; Mon, 20 Jun 2022 11:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IAr0nWWRh/5yNrTZZpTZkhs6Ii8uKHb4Moo48G9LkeA=; b=p6g4EEvhLTuj5cX+mI2KS4EfGcwS2p91AeAGCalKNna1BoCwkygii0hbAhllchfhTk 88SEePAwyVLzWldvnuX1q6Q07wJ24lLdix1H734KgJaTvZTzjkjWmz//XIJkdwkX5Xop SSo2yXKkthITVPj+H4KqIHJ9Gp1k3phlLWJYuVENuRxR+gRDXfwulmZ008PCxHcaIuBV uuT00LDl1/2+dELFNhqWLEE5WyltFOvXOkpIg80i8rT2/nu4RIEoVWyTYojnCYsF6ywi qhOI/Dza4LqW6uaWkn+9+ZLLn6WU8eF51UBN6PjjGACdfNMqXqrh6j2ykv08JLMfYhOU bUcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IAr0nWWRh/5yNrTZZpTZkhs6Ii8uKHb4Moo48G9LkeA=; b=4jw2yySKxoksitkYtsBjDVz+gQsPCEg9SUvjMsgv3ij0XYYp2S6S+Qg2EWXAt5rOYH 49SuD2wasW3MudvRsBLenOdZmRk1ijAzZrTH+uwDyRHQQ50KXYVSKed7TH2aIYkr+rA/ M/9GqpBiVzzsNY/sU2r3crdqelVBjANkDMtue72YHztOwb8g1EfgTG6Uvc6JLVwE34js 9eAQy/CakusQ9PcMslPzfzrn/iCeKpUoR1LilKx4a7vM0pKLOrPev3KC0h2KsnLcug1O Au2RYR7Dzbh9scJeJLEhNzZUwvTM4Qo2pzXDO/K3nt/q2SXXXF8IDpXKlrfih7VdEwZt rd/w== X-Gm-Message-State: AJIora+/ie1l8ExFSGmOxogJXe+hACjnLBXdl960ED481zvj6CGzNG14 c9S4z+OQf30s54d3SZmPb39UsQ== X-Google-Smtp-Source: AGRyM1v2UNQRfCicTojtbhCUvZybJsAchXa6JlgnEpul7Aefh3vwdNkSl0iZYkz+6LH+Gib9Tf7j1w== X-Received: by 2002:a17:903:48b:b0:16a:555:414a with SMTP id jj11-20020a170903048b00b0016a0555414amr18584958plb.67.1655749685817; Mon, 20 Jun 2022 11:28:05 -0700 (PDT) Received: from ?IPV6:2602:47:d49e:3c01:a3e0:8a80:7b85:aea6? ([2602:47:d49e:3c01:a3e0:8a80:7b85:aea6]) by smtp.gmail.com with ESMTPSA id u23-20020a1709026e1700b001620db30cd6sm8977813plk.201.2022.06.20.11.28.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 11:28:05 -0700 (PDT) Message-ID: <0d822ee9-89f2-9ad8-c3ad-3f7a6c0abf75@linaro.org> Date: Mon, 20 Jun 2022 11:28:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 02/10] bsd-user: Implement symlink, symlinkat, readlink and readlinkat Content-Language: en-US To: Warner Losh , qemu-devel@nongnu.org Cc: Kyle Evans , Stacey Son , Jung-uk Kim References: <20220620174220.22179-1-imp@bsdimp.com> <20220620174220.22179-3-imp@bsdimp.com> From: Richard Henderson In-Reply-To: <20220620174220.22179-3-imp@bsdimp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/20/22 10:42, Warner Losh wrote: > +static abi_long do_bsd_readlink(CPUArchState *env, abi_long arg1, > + abi_long arg2, abi_long arg3) > +{ > + abi_long ret; > + void *p1, *p2; > + > + LOCK_PATH(p1, arg1); > + p2 = lock_user(VERIFY_WRITE, arg2, arg3, 0); > + if (p2 == NULL) { > + UNLOCK_PATH(p1, arg1); > + return -TARGET_EFAULT; > + } > +#ifdef __FreeBSD__ > + if (strcmp(p1, "/proc/curproc/file") == 0) { > + CPUState *cpu = env_cpu(env); > + TaskState *ts = (TaskState *)cpu->opaque; > + strncpy(p2, ts->bprm->fullpath, arg3); > + ret = MIN((abi_long)strlen(ts->bprm->fullpath), arg3); > + } else > +#endif Unfortunate ifdef. Do we really need it while the other bsds are presumably still non-functional? I see that HOST_DEFAULT_BSD_TYPE isn't hooked up either... r~