qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Marcello Sylverster Bauer <sylv@sylv.io>, qemu-devel@nongnu.org
Cc: mst@redhat.com, imammedo@redhat.com, ani@anisinha.ca,
	Patrick Rudolph <patrick.rudolph@9elements.com>
Subject: Re: PCI Hotplug ACPI device names only 3 characters long
Date: Tue, 5 Sep 2023 17:09:18 +0200	[thread overview]
Message-ID: <0d882c9c-a95c-3c0b-8e95-da729ad16b32@linaro.org> (raw)
In-Reply-To: <66949448-1577-444a-b6d2-d907f9870765@sylv.io>

Hi Marcello,

On 5/9/23 17:05, Marcello Sylverster Bauer wrote:
> Greetings,
> 
> I'm currently working on a project to support Intel IPU6 in QEMU via 
> VFIO so that the guest system can access the camera. This requires 
> extending the ACPI device definition so that the guest knows how to 
> access the camera.
> 
> However, I cannot extend the PCI devices because their names are not 4 
> characters long and therefore do not follow the ACPI specification.
> 
> When I use '-acpitable' to include my own SSDT for the IPU6 PCI device, 
> it does not allow me to declare the device as an External Object because 
> it automatically adds padding underscores.
> 
> e.g.
> Before:
> ```
> External(_SB.PCI0.S18.SA0, DeviceObj)
> ```
> After:
> ```
> External(_SB.PCI0.S18_.SA0_, DeviceObj)
> ```

What do you mean by "before" / "after"?

> Adding the underscore padding is hard coded in iASL and also in QEMU 
> when parsing an ASL file. (see: build_append_nameseg())
> 
> So here are my questions:
> 1. Is there a solution to extend the ACPI PCI device using '-acpitable' 
> without having to patch iASL or QEMU?
> 2. Are there any plans to change the names to comply with the ACPI spec? 
> (e.g. use "S%.03X" format string instead)
> 
> Thanks
> Marcello
> 



  reply	other threads:[~2023-09-05 15:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 15:05 PCI Hotplug ACPI device names only 3 characters long Marcello Sylverster Bauer
2023-09-05 15:09 ` Philippe Mathieu-Daudé [this message]
2023-09-05 15:21   ` Marcello Sylverster Bauer
2023-09-05 16:44 ` Michael S. Tsirkin
2023-09-05 17:45   ` Marcello Sylverster Bauer
2023-09-05 20:43     ` Michael S. Tsirkin
2023-09-06  8:19       ` Igor Mammedov
2023-09-06 10:45         ` Marcello Sylverster Bauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d882c9c-a95c-3c0b-8e95-da729ad16b32@linaro.org \
    --to=philmd@linaro.org \
    --cc=ani@anisinha.ca \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=patrick.rudolph@9elements.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sylv@sylv.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).