Re: [PULL 00/32] target-arm queue

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 7/5/25 16:05, Stefan Hajnoczi wrote:
> On Tue, May 6, 2025 at 10:52 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> Now I'm back from holiday, here's a target-arm pullreq :-)
>>
>> thanks
>> -- PMM
>>
>> The following changes since commit a9e0c9c0f14e19d23443ac24c8080b4708d2eab8:
>>
>>    Merge tag 'pull-9p-20250505' of https://github.com/cschoenebeck/qemu into staging (2025-05-05 11:26:59 -0400)
>>
>> are available in the Git repository at:
>>
>>    https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20250506
>>
>> for you to fetch changes up to 607e1208b53ac713a76d158f4abc4cd2e8870051:
>>
>>    hw/arm/virt: Remove deprecated virt-4.0 machine (2025-05-06 15:02:35 +0100)
>>
>> ----------------------------------------------------------------
>> target-arm queue:
>>   * hw/arm/npcm8xx_boards: Correct valid_cpu_types setting of NPCM8XX SoC
>>   * arm/hvf: fix crashes when using gdbstub
>>   * target/arm/ptw: fix arm_cpu_get_phys_page_attrs_debug
>>   * hw/arm/virt: Remove deprecated old versions of 'virt' machine
>>   * tests/functional: Add test for imx8mp-evk board with USDHC coverage
>>   * hw/arm: Attach PSPI module to NPCM8XX SoC
>>   * target/arm: Don't assert() for ISB/SB inside IT block
>>   * docs: Don't define duplicate label in qemu-block-drivers.rst.inc
>>   * target/arm/kvm: Drop support for kernels without KVM_ARM_PREFERRED_TARGET
>>   * hw/pci-host/designware: Fix viewport configuration
>>   * hw/gpio/imx_gpio: Fix interpretation of GDIR polarity
>>
>> ----------------------------------------------------------------
>> Bernhard Beschow (4):
>>        tests/functional: Add test for imx8mp-evk board with USDHC coverage
>>        hw/pci-host/designware: Remove unused include
>>        hw/pci-host/designware: Fix viewport configuration
>>        hw/gpio/imx_gpio: Fix interpretation of GDIR polarity
>>
>> Mads Ynddal (2):
>>        hvf: avoid repeatedly setting trap debug for each cpu
>>        hvf: only update sysreg from owning thread
> 
> Please take a look at the following aarch64 macOS CI failure:
> 
> ../accel/hvf/hvf-all.c:61:54: error: unknown type name 'run_on_cpu_data'
> 61 | static void do_hvf_update_guest_debug(CPUState *cpu, run_on_cpu_data arg)
> | ^
> ../accel/hvf/hvf-all.c:68:5: error: call to undeclared function
> 'run_on_cpu'; ISO C99 and later do not support implicit function
> declarations [-Wimplicit-function-declaration]
> 68 | run_on_cpu(cpu, do_hvf_update_guest_debug, RUN_ON_CPU_NULL);
> | ^
> ../accel/hvf/hvf-all.c:68:48: error: use of undeclared identifier
> 'RUN_ON_CPU_NULL'
> 68 | run_on_cpu(cpu, do_hvf_update_guest_debug, RUN_ON_CPU_NULL);
> | ^
> 3 errors generated.
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/9962088576

"hvf: only update sysreg from owning thread" missing:

-- >8 --
diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c
index 3fc65d6b231..8c387fda24d 100644
--- a/accel/hvf/hvf-all.c
+++ b/accel/hvf/hvf-all.c
@@ -12,6 +12,7 @@
  #include "qemu/error-report.h"
  #include "system/hvf.h"
  #include "system/hvf_int.h"
+#include "hw/core/cpu.h"

  const char *hvf_return_string(hv_return_t ret)
  {
---