From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brpsP-0007Rv-6M for qemu-devel@nongnu.org; Wed, 05 Oct 2016 13:21:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brpsN-00050I-91 for qemu-devel@nongnu.org; Wed, 05 Oct 2016 13:21:04 -0400 References: <1475685327-22767-1-git-send-email-pbonzini@redhat.com> <1475685327-22767-3-git-send-email-pbonzini@redhat.com> From: Max Reitz Message-ID: <0d9f78e2-4983-f1d8-779a-867bd2ac92ef@redhat.com> Date: Wed, 5 Oct 2016 19:20:53 +0200 MIME-Version: 1.0 In-Reply-To: <1475685327-22767-3-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nJ7nVUOBE8gpWDkdR8SI75niFAlFqqxX0" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] quorum: do not allocate multiple iovecs for FIFO strategy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nJ7nVUOBE8gpWDkdR8SI75niFAlFqqxX0 From: Max Reitz To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org Message-ID: <0d9f78e2-4983-f1d8-779a-867bd2ac92ef@redhat.com> Subject: Re: [Qemu-block] [PATCH 2/2] quorum: do not allocate multiple iovecs for FIFO strategy References: <1475685327-22767-1-git-send-email-pbonzini@redhat.com> <1475685327-22767-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1475685327-22767-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 05.10.2016 18:35, Paolo Bonzini wrote: > In FIFO mode there are no parallel reads, hence there is no need to > allocate separate buffers and clone the iovecs. >=20 > The two cases of quorum_aio_cb are now even more different, and > most of quorum_aio_finalize is only needed in one of them, so split > them in separate functions. >=20 > Signed-off-by: Paolo Bonzini > --- > block/quorum.c | 79 +++++++++++++++++++++++++++++---------------------= -------- > 1 file changed, 40 insertions(+), 39 deletions(-) Reviewed-by: Max Reitz --nJ7nVUOBE8gpWDkdR8SI75niFAlFqqxX0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJX9TZ1EhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQINh CADErb2QARjDW/7wPzPlWldxcS32oNGF60vJ3Ac3crXDaYUfrcJz8GP5KaOI5/v2 lvGVATkps/TPbteQw2Wrj2zVyUAweJuPo39ffiO95nR0zd09irkbeb37bpLz8U5w NsBdIXagTiwo4j0CDPsyNtGtaz/aVzt12NUqBPDPjX7DVPjPTV4N1pqoOtq9PrjV aTA3qmg73bM5YPWKUGF1HWo132JgDHtz1lFbmTBM9QWaO8C17HxpK84K2oeCCVBA 9ZZj4jEFRxWd4FR7njH9qByldYCRycYlaVeAY0ZZkmUm1gAb/Mpubyemiv+/ndUp VyIPHAQA+Qh7DX3P6gCQ4VD2 =t2dA -----END PGP SIGNATURE----- --nJ7nVUOBE8gpWDkdR8SI75niFAlFqqxX0--