From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] block: Create the commit block job before reopening any image
Date: Fri, 27 May 2016 13:10:56 +0200 [thread overview]
Message-ID: <0da3b0b3-c17c-9428-5706-99f9bcee2d4b@redhat.com> (raw)
In-Reply-To: <aa495045770a6f1a7cc5d408397a17c75097fdd8.1464346103.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On 27.05.2016 12:53, Alberto Garcia wrote:
> If the base or overlay images need to be reopened in read-write mode
> but the block_job_create() call fails then no one will put those
> images back in read-only mode.
>
> We can solve this problem easily by calling block_job_create() first.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/commit.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-27 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 10:53 [Qemu-devel] [PATCH 0/4] Misc block job patches Alberto Garcia
2016-05-27 10:53 ` [Qemu-devel] [PATCH 1/4] block: use the block job list in bdrv_drain_all() Alberto Garcia
2016-05-27 10:58 ` Max Reitz
2016-05-27 10:53 ` [Qemu-devel] [PATCH 2/4] block: use the block job list in qmp_query_block_jobs() Alberto Garcia
2016-05-27 11:01 ` Max Reitz
2016-05-27 10:53 ` [Qemu-devel] [PATCH 3/4] block: Prevent sleeping jobs from resuming if they have been paused Alberto Garcia
2016-05-27 11:07 ` Max Reitz
2016-05-27 10:53 ` [Qemu-devel] [PATCH 4/4] block: Create the commit block job before reopening any image Alberto Garcia
2016-05-27 11:10 ` Max Reitz [this message]
2016-05-27 11:12 ` [Qemu-devel] [PATCH 0/4] Misc block job patches Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0da3b0b3-c17c-9428-5706-99f9bcee2d4b@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).