From: Anton Johansson via <qemu-devel@nongnu.org>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, richard.henderson@linaro.org,
philmd@linaro.org, ale@rev.ng, bcain@quicinc.com,
quic_mathbern@quicinc.com
Subject: Re: [PATCH v2] target/hexagon: fix = vs. == mishap
Date: Thu, 4 May 2023 16:55:45 +0200 [thread overview]
Message-ID: <0daaf7f3-044c-5b23-94b8-577ba4ebb3be@rev.ng> (raw)
In-Reply-To: <20230428204411.1400931-1-tsimpson@quicinc.com>
On 4/28/23 22:44, Taylor Simpson wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> **** Changes in v2 ****
> Fix yyassert's for sign and zero extends
>
> Coverity reports a parameter that is "set but never used". This is caused
> by an assignment operator being used instead of equality.
>
> Co-authored-by: Taylor Simpson <tsimpson@quicinc.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> target/hexagon/idef-parser/parser-helpers.c | 2 +-
> target/hexagon/idef-parser/idef-parser.y | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Tested-by: Anton Johansson <anjo@rev.ng>
prev parent reply other threads:[~2023-05-04 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 20:44 [PATCH v2] target/hexagon: fix = vs. == mishap Taylor Simpson
2023-04-29 9:27 ` Peter Maydell
2023-04-29 19:47 ` Taylor Simpson
2023-04-29 12:23 ` Paolo Bonzini
2023-04-29 19:27 ` Taylor Simpson
2023-05-04 14:55 ` Anton Johansson via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0daaf7f3-044c-5b23-94b8-577ba4ebb3be@rev.ng \
--to=qemu-devel@nongnu.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=quic_mathbern@quicinc.com \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).