From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CA3DC77B78 for ; Thu, 4 May 2023 17:40:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pucpS-00014G-E3; Thu, 04 May 2023 13:33:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puaNr-0002K4-1B for qemu-devel@nongnu.org; Thu, 04 May 2023 10:56:39 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puaNp-0008K3-Ag for qemu-devel@nongnu.org; Thu, 04 May 2023 10:56:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References: Cc:To:Subject:Reply-To:MIME-Version:Date:Message-ID:Sender:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7aYgpb3wTPVxezC9tuziG0biPQgSXX91yuA5LybRUzw=; b=TxhJyjlHLNhQCG7yWq2BH6Zv43 hKjWSMlh4A2t6R99845xDOxeWB5UglRTFJZh6I5SD+NqZOsM+hI7ItSPyGg6anfNSqlcsyAUkAdRO dq9L0kOFCnSFjoL+YPn+JOAA7Psa/SL+yQ7SMfPt86cDv5c1HrWn2VOoEf5PEyDn4NgE=; Message-ID: <0daaf7f3-044c-5b23-94b8-577ba4ebb3be@rev.ng> Date: Thu, 4 May 2023 16:55:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v2] target/hexagon: fix = vs. == mishap To: Taylor Simpson , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, bcain@quicinc.com, quic_mathbern@quicinc.com References: <20230428204411.1400931-1-tsimpson@quicinc.com> Content-Language: en-US Organization: rev.ng In-Reply-To: <20230428204411.1400931-1-tsimpson@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -63 X-Spam_score: -6.4 X-Spam_bar: ------ X-Spam_report: (-6.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.28, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: anjo@rev.ng X-ACL-Warn: , Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/28/23 22:44, Taylor Simpson wrote: > From: Paolo Bonzini > > **** Changes in v2 **** > Fix yyassert's for sign and zero extends > > Coverity reports a parameter that is "set but never used". This is caused > by an assignment operator being used instead of equality. > > Co-authored-by: Taylor Simpson > Signed-off-by: Paolo Bonzini > Signed-off-by: Taylor Simpson > --- > target/hexagon/idef-parser/parser-helpers.c | 2 +- > target/hexagon/idef-parser/idef-parser.y | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Anton Johansson Tested-by: Anton Johansson