From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36665C433E0 for ; Fri, 10 Jul 2020 18:16:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 009CC20720 for ; Fri, 10 Jul 2020 18:16:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hZrPguzQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 009CC20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtxZm-0001CI-5E for qemu-devel@archiver.kernel.org; Fri, 10 Jul 2020 14:16:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtxYh-0000Ah-4j for qemu-devel@nongnu.org; Fri, 10 Jul 2020 14:15:39 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:39946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jtxYe-0004BZ-D0 for qemu-devel@nongnu.org; Fri, 10 Jul 2020 14:15:38 -0400 Received: by mail-pg1-x530.google.com with SMTP id e18so2873006pgn.7 for ; Fri, 10 Jul 2020 11:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=whVeT42wRXTpzJNWOVvJaKOIZq0iTJhITxhcz8Zntv4=; b=hZrPguzQZw0bh29Jm8ptcnowu1/BY2+1fpEGKjQ5Wv9UBwyG8Z5nrVMCMWog3ip7an mUI8nN8qZKNDK1iFOL3ESQdtsbCBSrD0MV+HphTS2g1W1CsXdTfCjEtuQFPW+P2ohThV 7xxkuNQ2A7KUo41lnEPI/2UskmsNVlwo1OqlxNWskkpU/U61OAnVaaDnSqf/OPIdGCDi 9JcYlNulsK1vBYqPjNP0xLk1hvSSn1Gv0Vcpi+TeFD27HXHIAu2NqXJu0IEn1ov0lkJ6 H0hrgmzqcGjHn4vfR5c2KhHnt8QZU0W3iCnSZ0ehQ15WH3UrYWX0lIKvEeC3cr5RbfRV pkTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=whVeT42wRXTpzJNWOVvJaKOIZq0iTJhITxhcz8Zntv4=; b=uKt9N/a72Bg1Ap7xbw28SMZtc78Kvh0KqATrKEKhf0T3H0t3klzOgCLQsn3H2pqXJD B7FaHnMQRDe+kjoB2VonICu7hfpRxv8jXXMRttlNK0aQa22BudlJqbt3zPFjqbnfxdfF PUve4STIohRA6YnWm5oU//qfN6bsigkS4UPSEWqf/W4m2lSbWr7N2VkreXa7SSw+YtRP KOeBIAcRf4eJ035h8uAxG67D3ohz/FxkM5fu1Bq55138mr/IMXQkLJT8LDACalNw4Fi1 EdVlpU2R+3ZR5aj677ZcG4JV8cGrdGCjFx3Ggfe6I82wbsxS+aukAdJDRQiafRlkpc4G g5pg== X-Gm-Message-State: AOAM5336BRNDL+vClGEY1JfYsB2gTLfqP360QJeIhP5/y/+9xL0RPCP+ 88DgpCmQixWbYrNf+x9qmpq3vQ== X-Google-Smtp-Source: ABdhPJx/Ms73ovz36oeiSFtJOm3lwqC1VblrvPXpMTI0QyBvWhMovnVedfr33MPMvTmvx0CAsW4B2Q== X-Received: by 2002:a63:778c:: with SMTP id s134mr57276224pgc.273.1594404933895; Fri, 10 Jul 2020 11:15:33 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id r204sm6913827pfc.134.2020.07.10.11.15.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 11:15:32 -0700 (PDT) Subject: Re: [RFC 14/65] target/riscv: rvv-0.9: stride load and store instructions To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20200710104920.13550-1-frank.chang@sifive.com> <20200710104920.13550-15-frank.chang@sifive.com> From: Richard Henderson Message-ID: <0dc40d00-a89d-9818-9fd3-2bce4141eca7@linaro.org> Date: Fri, 10 Jul 2020 11:15:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200710104920.13550-15-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , Palmer Dabbelt , LIU Zhiwei , Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/10/20 3:48 AM, frank.chang@sifive.com wrote: > # *** Vector loads and stores are encoded within LOADFP/STORE-FP *** > -vlb_v ... 100 . 00000 ..... 000 ..... 0000111 @r2_nfvm > -vlh_v ... 100 . 00000 ..... 101 ..... 0000111 @r2_nfvm > -vlw_v ... 100 . 00000 ..... 110 ..... 0000111 @r2_nfvm Again, something you can't do until 0.7.1 is not supported. If you don't want to simultaneously support 0.7.1 and 0.9/1.0, then you should simply remove 0.7.1 in the first patch, so that there's no confusion. Is the rest of it mostly renaming? You should definitely expand on what you're doing within each patch description. A description of what has changed in the spec since 0.7.1 will help the reviewer validate that you've gotten all of the corner cases. I am going to stop reviewing this patch series now, as I expect that most of the remaining patches will have similar comments. r~