From: Dennis Clarke <dclarke@blastwave.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
qemu-ppc <qemu-ppc@nongnu.org>, "Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()
Date: Tue, 21 Apr 2020 12:07:39 -0400 [thread overview]
Message-ID: <0dd1ec76-6d57-a4bb-96be-cc30caa00254@blastwave.org> (raw)
In-Reply-To: <1918bd79-2e30-a578-c34e-683eab724c67@amsat.org>
On 2020-04-21 03:17, Philippe Mathieu-Daudé wrote:
> On 4/21/20 12:53 AM, Dennis Clarke wrote:
>> On 4/20/20 6:56 PM, Peter Maydell wrote:
>>> On Fri, 17 Apr 2020 at 10:08, Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> wrote:
>>>>
>>>> This fixes:
>>>>
>>>> $ qemu-system-ppc64 \
>>>> -machine pseries-4.1 -cpu power9 \
>>>> -smp 4 -m 12G -accel tcg ...
>>>> ...
>>>> Quiescing Open Firmware ...
>>>> Booting Linux via __start() @ 0x0000000002000000 ...
>>>> Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
>>>> Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
>>>> Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
>>>>
>>>> [*] https://www.mail-archive.com/qemu-discuss@nongnu.org/msg05400.html
>>>>
>>>> Fixes: 0418bf78fe8 ("Fix ISA v3.0 (POWER9) slbia implementation")
>>>> Reported-by: Dennis Clarke <dclarke@blastwave.org>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>
>>> I propose to apply this patch for 5.0 rc4 (as well as the
>>> ppc pullreq already sent), since the iscsi bugfix means
>>> we need an rc4 anyway. Any objections?
>>>
>>
>> I have been running rc3 with this patch fine for some days now. Both
>> with and without a debug enabled build wherein the performance
>> difference between the two is obvious.
>
> Thanks for testing it! Can we use your:
>
> Tested-by: Dennis Clarke <dclarke@blastwave.org>
>
> tag?
Of course. Even "running fine by that old UNIX guy" if you want.
--
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional
next prev parent reply other threads:[~2020-04-21 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 9:07 [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia() Philippe Mathieu-Daudé
2020-04-17 10:51 ` Nicholas Piggin
2020-04-17 11:00 ` Philippe Mathieu-Daudé
2020-04-18 10:45 ` Nicholas Piggin
2020-04-17 12:46 ` Cédric Le Goater
2020-04-20 18:56 ` Peter Maydell
2020-04-20 22:53 ` Dennis Clarke
2020-04-21 0:49 ` David Gibson
2020-04-21 7:17 ` Philippe Mathieu-Daudé
2020-04-21 16:07 ` Dennis Clarke [this message]
2020-04-21 0:31 ` David Gibson
2020-04-21 9:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dd1ec76-6d57-a4bb-96be-cc30caa00254@blastwave.org \
--to=dclarke@blastwave.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=npiggin@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).