Re: [Qemu-devel] [PATCH v2 8/8] ui: add ability to specify multiple VNC listen addresses

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

On 01/24/2017 03:53 AM, Daniel P. Berrange wrote:
> This change allows the listen address and websocket address
> options for -vnc to be repeated. This causes the VNC server
> to listen on multiple addresses. e.g.
> 
>  $ $QEMU -vnc vnc=localhost:1,vnc=unix:/tmp/vnc,\
>               websocket=127.0.0.1:8080,websocket=[::]:8081
> 
> results in listening on
> 
> 127.0.0.1:5901, 127.0.0.1:8080, ::1:5901, :::8081 & /tmp/vnc
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  ui/vnc.c | 198 +++++++++++++++++++++++++++++++++++++++++++--------------------
>  1 file changed, 135 insertions(+), 63 deletions(-)
> 

> @@ -3835,7 +3901,9 @@ void vnc_display_open(const char *id, Error **errp)
>          return;
>      }
>  
> -    if (vnc_display_get_addresses(opts, &saddr, &wsaddr, errp) < 0) {
> +    if (vnc_display_get_addresses(opts, &saddr, &nsaddr,
> +                                  &wsaddr, &nwsaddr, errp) < 0) {
> +        g_printerr("failing\n");
>          goto fail;

Leftover debugging?

Otherwise looks okay, so with that line gone,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]