From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76504C2D0DB for ; Tue, 28 Jan 2020 20:24:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32513206A2 for ; Tue, 28 Jan 2020 20:24:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TQkEqr0m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32513206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwXPR-0004jf-Ai for qemu-devel@archiver.kernel.org; Tue, 28 Jan 2020 15:24:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40040) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwXOh-00041C-1g for qemu-devel@nongnu.org; Tue, 28 Jan 2020 15:23:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwXOf-0002iq-J6 for qemu-devel@nongnu.org; Tue, 28 Jan 2020 15:23:42 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:59116 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iwXOf-0002gr-Fq for qemu-devel@nongnu.org; Tue, 28 Jan 2020 15:23:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580243021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qgVxJ0FiX0XFhW50/G5ckJdu9IU+U+OKfSKSSF8FeBM=; b=TQkEqr0ma+kgGSdroBS3FRuDYjfskRvmA8tu7W4xSrpaKF2NEZsdSxR71Ici+5yH+BgXFX mT3pt7EfkHSphe+V7GvET9LtJN40mr8t9DCSO8uu/BE4JpU1PsdkG29Cg9eW41V0MQ1+Zu V2POPgf9R+650R7r+s3IfTkWiUxoJ04= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-82-Lv8HEl7HNcWztAszEFqaUQ-1; Tue, 28 Jan 2020 15:23:34 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6228800D41; Tue, 28 Jan 2020 20:23:32 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-65.gru2.redhat.com [10.97.116.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CFB45C219; Tue, 28 Jan 2020 20:23:20 +0000 (UTC) Subject: Re: [PATCH v4 7/7] tests/boot_linux_console: Tag Emcraft Smartfusion2 as running 'u-boot' To: Thomas Huth , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200120235159.18510-1-f4bug@amsat.org> <20200120235159.18510-8-f4bug@amsat.org> From: Wainer dos Santos Moschetta Message-ID: <0debd0ec-16e4-2d96-c634-26bdb6db6215@redhat.com> Date: Tue, 28 Jan 2020 18:23:18 -0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: Lv8HEl7HNcWztAszEFqaUQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Alistair Francis , Andrew Baumann , qemu-arm@nongnu.org, Cleber Rosa , Laurent Bonnans , Cheng Xiang , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/27/20 2:05 PM, Thomas Huth wrote: > On 21/01/2020 00.51, Philippe Mathieu-Daud=C3=A9 wrote: >> Avocado tags are handy to automatically select tests matching >> the tags. Since this test also runs U-Boot, tag it. >> >> We can run all the tests using U-Boot as once with: >> >> $ avocado --show=3Dapp run -t u-boot tests/acceptance/ >> JOB LOG : avocado/job-results/job-2020-01-21T00.16-ee9344e/job.log >> (1/3) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_a= rm_emcraft_sf2: PASS (16.59 s) >> (2/3) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_a= rm_raspi2_uboot: PASS (0.47 s) >> (3/3) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_a= arch64_raspi3_uboot: PASS (2.43 s) >> RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT = 0 | CANCEL 0 >> JOB TIME : 19.78 s >> >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >> --- >> tests/acceptance/boot_linux_console.py | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/b= oot_linux_console.py >> index 22b360118d..4a4cf9d0ea 100644 >> --- a/tests/acceptance/boot_linux_console.py >> +++ b/tests/acceptance/boot_linux_console.py >> @@ -305,6 +305,7 @@ class BootLinuxConsole(Test): >> :avocado: tags=3Darch:arm >> :avocado: tags=3Dmachine:emcraft-sf2 >> :avocado: tags=3Dendian:little >> + :avocado: tags=3Du-boot >> """ >> uboot_url =3D ('https://raw.githubusercontent.com/' >> 'Subbaraya-Sundeep/qemu-test-binaries/' >> > We should maybe move that test to another file, too, since it is not > using Linux. Or should we maybe rename boot_linux_console.py to simply > boot_console.py ? Thinking aloud: maybe create a directory 'boot' (or 'boot_tests') and=20 group tests in files according to the 'arch' tag. Example: [wainersm@localhost boot]$ tree . =E2=94=94=E2=94=80=E2=94=80 arm.py 0 directories, 1 file [wainersm@localhost boot]$ cat arm.py from avocado_qemu import Test class BootArmTest(Test): =C2=A0=C2=A0=C2=A0 """ =C2=A0=C2=A0=C2=A0 :avocado: tags=3Darch:arm =C2=A0=C2=A0=C2=A0 """ =C2=A0=C2=A0=C2=A0 def test_linux_virt() =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :avocado: tags=3Dmachine:virt =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :avocado: tags=3Dlinux-boot =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # Test here =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pass =C2=A0=C2=A0=C2=A0 def test_uboot_emcraft_sf2() =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :avocado: tags=3Dmachine:emcraf= t-sf2 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :avocado: tags=3Dendian:little =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :avocado: tags=3Du-boot =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # Test here =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pass -------------- Back to this patch... Reviewed-by: Wainer dos Santos Moschetta > > Thomas > >