qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] char: do not use atexit cleanup handler
Date: Mon, 4 Jul 2016 19:08:41 +0200	[thread overview]
Message-ID: <0e0b3d90-24c2-519f-7b08-2b1174b35dc9@redhat.com> (raw)
In-Reply-To: <20160704170715.GO3763@redhat.com>



On 04/07/2016 19:07, Daniel P. Berrange wrote:
> > At this point you have stopped all CPUs and block devices.  There is not
> > much else that is going on in QEMU at all, at this point.  The solution
> > would be to stop those threads.
>
> What about graphics threads ? In particular I'd be thinking of spice
> which uses threads and chardevs.

I think it should be quiesced after pause_all_vcpus returns.  Marc-André
should know, but it's better to check with Gerd.

(FWIW, it's not so easy to shut down the threads because for example
some threads might belong to non-hotunpluggable devices).

Paolo

  reply	other threads:[~2016-07-04 17:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 15:38 [Qemu-devel] [PATCH] char: do not use atexit cleanup handler marcandre.lureau
2016-07-04 15:49 ` Paolo Bonzini
2016-07-04 16:31 ` Daniel P. Berrange
2016-07-04 16:43   ` Marc-André Lureau
2016-07-04 17:12     ` Daniel P. Berrange
2016-07-04 16:46   ` Paolo Bonzini
2016-07-04 17:07     ` Daniel P. Berrange
2016-07-04 17:08       ` Paolo Bonzini [this message]
2016-07-04 17:19         ` Marc-André Lureau
2016-07-04 19:53           ` Gerd Hoffmann
2016-07-05  8:24             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e0b3d90-24c2-519f-7b08-2b1174b35dc9@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).