From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] meson: use pkg-config method to find dependencies
Date: Mon, 31 Aug 2020 14:15:23 +0200 [thread overview]
Message-ID: <0e111925-dded-3866-cfd7-6de152f7e95c@redhat.com> (raw)
In-Reply-To: <20200831110655.uj6f2hq3yyygqqox@sirius.home.kraxel.org>
On 31/08/20 13:06, Gerd Hoffmann wrote:
>
>> Keep "auto" for SDL so that it tries using
>> sdl-config too.
>> - sdl = dependency('sdl2',
>> - required: get_option('sdl'),
>> + sdl = dependency('sdl2', required: get_option('sdl'),
>> + method: 'pkg-config',
> code and commit message mismatch here.
That's docs/devel/build-system.rst, I wanted to keep the "method" so
that people can cut-and-paste correctly.
Would you prefer if I switched from sdl2 to something else (for example
pixman which has a "version" keyword argument as well)?
Paolo
next prev parent reply other threads:[~2020-08-31 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 10:28 [PATCH] meson: use pkg-config method to find dependencies Paolo Bonzini
2020-08-31 11:06 ` Gerd Hoffmann
2020-08-31 12:15 ` Paolo Bonzini [this message]
2020-09-01 5:00 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e111925-dded-3866-cfd7-6de152f7e95c@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).