From: Max Reitz <mreitz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Bruce Rogers <brogers@suse.com>,
Claudio Fontana <cfontana@suse.de>,
Thomas Huth <thuth@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Cc: "Jason J. Herne" <jjherne@linux.ibm.com>,
Fam Zheng <fam@euphon.net>, Liang Yan <lyan@suse.com>,
Peter Maydell <peter.maydell@linaro.org>,
Cornelia Huck <cohuck@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed
Date: Tue, 28 Jul 2020 13:45:01 +0200 [thread overview]
Message-ID: <0e175bbb-6d5e-f509-7a4f-e3e4769c13a1@redhat.com> (raw)
In-Reply-To: <dc30924a-11f8-f452-837e-ae5ee7ec9cc1@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 758 bytes --]
On 28.07.20 13:35, Paolo Bonzini wrote:
> On 28/07/20 13:33, Vladimir Sementsov-Ogievskiy wrote:
>>> Thanks for both your investigation. Does the attached patch help?
>>
>> For me, the reproducer is fixed with your patch.
>
> Is it possible to make a quick testcase using qemu-io?
This seems to work:
$ qemu-img create -f qcow2 -o cluster_size=512 base.qcow2 512
$ qemu-img create -f qcow2 -o cluster_size=512 -F qcow2 -b base.qcow2 \
top.qcow2 1024
$ qemu-io -c 'write -P 42 0 512' top.qcow2
$ qemu-io -c 'read -v 0 1024' top.qcow2
That should print 512 times “2a” and then 512 times “00”, but beyond
512, the buffer stays uninitialized; instead, the first 512 bytes are
zeroed. (With the patch, it works as expected.)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-28 11:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 10:00 migration: broken snapshot saves appear on s390 when small fields in migration stream removed Claudio Fontana
2020-07-12 16:11 ` Paolo Bonzini
2020-07-13 9:11 ` Claudio Fontana
2020-07-14 14:29 ` Claudio Fontana
2020-07-14 14:35 ` Thomas Huth
2020-07-15 11:10 ` Claudio Fontana
2020-07-15 12:25 ` Claudio Fontana
2020-07-16 12:58 ` Claudio Fontana
2020-07-20 18:24 ` Claudio Fontana
2020-07-21 8:22 ` Claudio Fontana
2020-07-27 23:09 ` Bruce Rogers
2020-07-28 8:15 ` Vladimir Sementsov-Ogievskiy
2020-07-28 8:43 ` Vladimir Sementsov-Ogievskiy
2020-07-28 13:23 ` Bruce Rogers
2020-07-28 11:10 ` Max Reitz
2020-07-28 11:27 ` Vladimir Sementsov-Ogievskiy
2020-07-28 11:33 ` Vladimir Sementsov-Ogievskiy
2020-07-28 11:35 ` Paolo Bonzini
2020-07-28 11:45 ` Max Reitz [this message]
2020-07-28 12:09 ` Paolo Bonzini
2020-07-28 12:47 ` Claudio Fontana
2020-07-13 11:03 ` Dr. David Alan Gilbert
2020-07-13 11:39 ` Cornelia Huck
2020-07-13 11:39 ` Claudio Fontana
2020-07-13 11:45 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e175bbb-6d5e-f509-7a4f-e3e4769c13a1@redhat.com \
--to=mreitz@redhat.com \
--cc=brogers@suse.com \
--cc=cfontana@suse.de \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=jjherne@linux.ibm.com \
--cc=kwolf@redhat.com \
--cc=lyan@suse.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).