From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] glib: use portable g_setenv()
Date: Wed, 11 Dec 2019 20:32:14 +0100 [thread overview]
Message-ID: <0e1b1e96-9780-7ee0-d463-2199ce66f840@redhat.com> (raw)
In-Reply-To: <1576074210-52834-7-git-send-email-pbonzini@redhat.com>
On 11/12/2019 15.23, Paolo Bonzini wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> We have a setenv() wrapper in os-win32.c that no one is actually using.
> Drop it and change to g_setenv() uniformly.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> include/sysemu/os-win32.h | 2 --
> os-win32.c | 22 ----------------------
> tests/libqtest.c | 2 +-
> tests/test-crypto-tlscredsx509.c | 2 +-
> tests/test-crypto-tlssession.c | 2 +-
> tests/test-io-channel-tls.c | 2 +-
> tests/test-vmstate.c | 2 +-
> ui/sdl2.c | 2 +-
> 8 files changed, 6 insertions(+), 30 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2019-12-11 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 14:23 [PATCH] glib: use portable g_setenv() Paolo Bonzini
2019-12-11 19:32 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e1b1e96-9780-7ee0-d463-2199ce66f840@redhat.com \
--to=thuth@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).