From: Max Reitz <mreitz@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3] block: change variable names in BlockDriverState
Date: Wed, 14 Jun 2017 19:01:45 +0200 [thread overview]
Message-ID: <0e4ce9ef-806f-81d9-fdbe-4741d8c158a7@redhat.com> (raw)
In-Reply-To: <20170609101808.13506-1-el13635@mail.ntua.gr>
[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]
On 2017-06-09 12:18, Manos Pitsidianakis wrote:
> Change the 'int count' parameter in *pwrite_zeros, *pdiscard related
> functions (and some others) to 'int bytes', as they both refer to bytes.
> This helps with code legibility.
>
> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
> ---
> block/blkdebug.c | 36 +++++++++++++++----------------
> block/blkreplay.c | 8 +++----
> block/block-backend.c | 22 +++++++++----------
> block/file-posix.c | 34 +++++++++++++++---------------
> block/io.c | 48 +++++++++++++++++++++---------------------
> block/iscsi.c | 20 +++++++++---------
> block/mirror.c | 8 +++----
> block/nbd-client.c | 8 +++----
> block/nbd-client.h | 4 ++--
> block/qcow2.c | 28 ++++++++++++------------
> block/qed.c | 8 +++----
> block/raw-format.c | 8 +++----
> block/rbd.c | 4 ++--
> block/sheepdog.c | 6 +++---
> include/block/block.h | 8 +++----
> include/block/block_int.h | 6 +++---
> include/sysemu/block-backend.h | 20 +++++++++---------
> qemu-io-cmds.c | 46 ++++++++++++++++++++--------------------
> 18 files changed, 161 insertions(+), 161 deletions(-)
Thank you, I've applied the patch to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 498 bytes --]
prev parent reply other threads:[~2017-06-14 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:18 [Qemu-devel] [PATCH v3] block: change variable names in BlockDriverState Manos Pitsidianakis
2017-06-12 14:23 ` Stefan Hajnoczi
2017-06-14 17:01 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4ce9ef-806f-81d9-fdbe-4741d8c158a7@redhat.com \
--to=mreitz@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).