From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>,
Fabiano Rosas <farosas@suse.de>,
qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alexander Graf" <agraf@csgraf.de>,
"Cornelia Huck" <cohuck@redhat.com>
Subject: Re: [RFC PATCH v4 15/15] arm/Kconfig: Do not build TCG-only boards on a KVM-only build
Date: Thu, 19 Jan 2023 21:08:10 +0100 [thread overview]
Message-ID: <0e4e2776-c44e-343b-1142-e236e38f35cc@linaro.org> (raw)
In-Reply-To: <d700c608-f886-8b6f-1ecf-bc48cf671153@linaro.org>
On 19/1/23 19:50, Richard Henderson wrote:
> On 1/19/23 03:54, Fabiano Rosas wrote:
>> Move all the CONFIG_FOO=y from default.mak into "default y if TCG"
>> statements in Kconfig. That way they won't be selected when
>> CONFIG_TCG=n.
>>
>> I'm leaving CONFIG_ARM_VIRT in default.mak because it allows us to
>> keep the two default.mak files not empty and keep aarch64-default.mak
>> including arm-default.mak. That way we don't surprise anyone that's
>> used to altering these files.
>>
>> With this change we can start building with --disable-tcg.
>>
>> Signed-off-by: Fabiano Rosas<farosas@suse.de>
>> ---
>> sbsa-ref has an explicit check to avoid running with KVM
>> xlnx-versal-virt has avocado tests tagged with tcg
>> ---
>> configs/devices/aarch64-softmmu/default.mak | 4 --
>> configs/devices/arm-softmmu/default.mak | 37 ------------------
>> hw/arm/Kconfig | 42 ++++++++++++++++++++-
>> 3 files changed, 41 insertions(+), 42 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
The previous version was cleaner IMHO, not restricting only the
machines but also the cores:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg777724.html
next prev parent reply other threads:[~2023-01-19 20:08 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 13:54 [RFC PATCH v4 00/15] target/arm: Allow CONFIG_TCG=n builds Fabiano Rosas
2023-01-19 13:54 ` [RFC PATCH v4 01/15] target/arm: Move 64-bit TCG CPUs into tcg/ Fabiano Rosas
2023-01-19 18:31 ` Richard Henderson
2023-01-19 19:07 ` Fabiano Rosas
2023-01-19 19:17 ` Richard Henderson
2023-01-19 13:54 ` [RFC PATCH v4 02/15] target/arm: move cpu_tcg to tcg/cpu32.c Fabiano Rosas
2023-01-19 13:54 ` [RFC PATCH v4 03/15] target/arm: Remove default cpu for KVM-only builds Fabiano Rosas
2023-01-19 20:19 ` Richard Henderson
2023-01-20 12:24 ` Daniel P. Berrangé
2023-01-19 13:54 ` [RFC PATCH v4 04/15] tests/qtest: arm-cpu-features: Match tests to required accelerators Fabiano Rosas
2023-01-19 18:37 ` Richard Henderson
2023-01-20 10:11 ` Thomas Huth
2023-01-19 13:54 ` [RFC PATCH v4 05/15] tests/qtest: Restrict tpm-tis-devices-{swtpm}-test to CONFIG_TCG Fabiano Rosas
2023-01-19 18:39 ` Richard Henderson
2023-01-20 10:14 ` Thomas Huth
2023-01-20 10:19 ` Thomas Huth
2023-01-19 13:54 ` [RFC PATCH v4 06/15] tests/qtest: Add qtest_get_machine_args Fabiano Rosas
2023-01-19 18:55 ` Richard Henderson
2023-01-20 11:48 ` Thomas Huth
2023-01-20 12:00 ` Cornelia Huck
2023-01-20 12:12 ` Thomas Huth
2023-01-19 13:54 ` [RFC PATCH v4 07/15] tests/qtest: Adjust qom-test to always set a -cpu option Fabiano Rosas
2023-01-19 19:00 ` Richard Henderson
2023-01-19 19:12 ` Fabiano Rosas
2023-01-19 13:54 ` [RFC PATCH v4 08/15] tests/qtest: Adjust test-hmp to always pass " Fabiano Rosas
2023-01-19 14:06 ` Dr. David Alan Gilbert
2023-01-19 14:39 ` Fabiano Rosas
2023-01-19 13:54 ` [RFC PATCH v4 09/15] tests/qtest: Adjust device-introspect-test to always set a " Fabiano Rosas
2023-01-19 13:54 ` [RFC PATCH v4 10/15] tests/qtest: aarch64: Set -cpu for numa-test Fabiano Rosas
2023-01-19 13:54 ` [RFC PATCH v4 11/15] tests/qemu-iotests: Allow passing a -cpu option in the QEMU cmdline Fabiano Rosas
2023-01-19 19:09 ` Richard Henderson
2023-01-19 19:21 ` Fabiano Rosas
2023-01-19 13:54 ` [RFC PATCH v4 12/15] tests/tcg: Do not build/run TCG tests if TCG is disabled Fabiano Rosas
2023-01-19 18:52 ` Richard Henderson
2023-01-19 19:49 ` Philippe Mathieu-Daudé
2023-01-19 13:54 ` [RFC PATCH v4 13/15] target/avocado: Pass parameters to migration test on aarch64 Fabiano Rosas
2023-01-19 19:29 ` Richard Henderson
2023-01-19 13:54 ` [RFC PATCH v4 14/15] arm/Kconfig: Always select SEMIHOSTING when TCG is present Fabiano Rosas
2023-01-19 18:50 ` Richard Henderson
2023-01-19 20:03 ` Philippe Mathieu-Daudé
2023-01-19 21:40 ` Fabiano Rosas
2023-01-19 13:54 ` [RFC PATCH v4 15/15] arm/Kconfig: Do not build TCG-only boards on a KVM-only build Fabiano Rosas
2023-01-19 18:50 ` Richard Henderson
2023-01-19 20:08 ` Philippe Mathieu-Daudé [this message]
2023-01-19 21:47 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4e2776-c44e-343b-1142-e236e38f35cc@linaro.org \
--to=philmd@linaro.org \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=farosas@suse.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).