Re: [PATCH 4/8] sclpconsole: Use TYPE_* constants

[Thomas Huth <thuth@redhat.com>]

On 26/08/2020 20.43, Eduardo Habkost wrote:
> This will make future conversion to use OBJECT_DECLARE* easier.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: qemu-s390x@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
>  hw/char/sclpconsole-lm.c | 2 +-
>  hw/char/sclpconsole.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c
> index 2b5f37b6a2..5848b4e9c5 100644
> --- a/hw/char/sclpconsole-lm.c
> +++ b/hw/char/sclpconsole-lm.c
> @@ -355,7 +355,7 @@ static void console_class_init(ObjectClass *klass, void *data)
>  }
>  
>  static const TypeInfo sclp_console_info = {
> -    .name          = "sclplmconsole",
> +    .name          = TYPE_SCLPLM_CONSOLE,
>      .parent        = TYPE_SCLP_EVENT,
>      .instance_size = sizeof(SCLPConsoleLM),
>      .class_init    = console_class_init,
> diff --git a/hw/char/sclpconsole.c b/hw/char/sclpconsole.c
> index 5c7664905e..d6f7da0818 100644
> --- a/hw/char/sclpconsole.c
> +++ b/hw/char/sclpconsole.c
> @@ -271,7 +271,7 @@ static void console_class_init(ObjectClass *klass, void *data)
>  }
>  
>  static const TypeInfo sclp_console_info = {
> -    .name          = "sclpconsole",
> +    .name          = TYPE_SCLP_CONSOLE,
>      .parent        = TYPE_SCLP_EVENT,
>      .instance_size = sizeof(SCLPConsole),
>      .class_init    = console_class_init,
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>