From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49765)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bFKJm-0000tp-4F
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 07:58:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bFKJh-00025L-CS
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 07:58:09 -0400
References: <1465808915-4887-1-git-send-email-vijayak@caviumnetworks.com>
	<1465808915-4887-4-git-send-email-vijayak@caviumnetworks.com>
	<16ef20d6-8c02-8617-0b6a-16fab76d3333@redhat.com>
	<CAFEAcA_A=f0H3DkquozZKKVs4A3UR+fEhE9wfwe8zDHrsprEyQ@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <0e6c012c-26c5-8878-f579-d2410c640cfb@redhat.com>
Date: Tue, 21 Jun 2016 13:57:53 +0200
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_A=f0H3DkquozZKKVs4A3UR+fEhE9wfwe8zDHrsprEyQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v1 3/4] translate-all.c: Compute L1
 page table properties at runtime
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Vijaya Kumar K <vijayak@caviumnetworks.com>, qemu-arm <qemu-arm@nongnu.org>, Juan Quintela <quintela@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijay Kilari <vijay.kilari@gmail.com>, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, Vijaya Kumar K <vijayak@cavium.com>



On 21/06/2016 13:53, Peter Maydell wrote:
>>> >>      object_property_add_child(object_get_root(), "machine",
>>> >>                                OBJECT(current_machine), &error_abort);
>>> >> +
>>> >> +    init_l1_page_table_param();
>> >
>> > Please call this from cpu_exec_init_all instead.
> If you're going to call it that early (ie before machine init)
> than I think we might as well just call it from the existing
> page_init() function in translate-all.c instead, right?
> (gets called when the tcg accelerator is inited; we don't need
> to set up the l1 map if we're not using TCG).

Yes, good idea.

Paolo