* [PATCH] tcg: Avoid including 'trace-tcg.h' in target translate.c
@ 2021-06-22 16:15 Philippe Mathieu-Daudé
2021-06-22 17:50 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-06-22 16:15 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, David Hildenbrand, Mark Cave-Ayland, Thomas Huth,
Philippe Mathieu-Daudé, Max Filippov, Edgar E. Iglesias,
Yoshinori Sato, Artyom Tarasenko, Aleksandar Rikalo,
Eduardo Habkost, Richard Henderson, Greg Kurz, qemu-s390x,
qemu-arm, Stafford Horne, David Gibson, Cornelia Huck,
Laurent Vivier, qemu-ppc, Paolo Bonzini, Aurelien Jarno
The root trace-events only declares a single TCG event:
$ git grep -w tcg trace-events
trace-events:115:# tcg/tcg-op.c
trace-events:137:vcpu tcg guest_mem_before(TCGv vaddr, uint16_t info) "info=%d", "vaddr=0x%016"PRIx64" info=%d"
and only a tcg/tcg-op.c uses it:
$ git grep -l trace_guest_mem_before_tcg
tcg/tcg-op.c
therefore it is pointless to include "trace-tcg.h" in each target
(because it is not used). Remove it.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/alpha/translate.c | 1 -
target/arm/translate-a64.c | 1 -
target/arm/translate-sve.c | 1 -
target/arm/translate.c | 1 -
target/cris/translate.c | 1 -
target/hppa/translate.c | 1 -
target/i386/tcg/translate.c | 1 -
target/m68k/translate.c | 1 -
target/microblaze/translate.c | 1 -
target/mips/tcg/translate.c | 1 -
target/openrisc/translate.c | 1 -
target/ppc/translate.c | 1 -
target/rx/translate.c | 1 -
target/s390x/translate.c | 1 -
target/sh4/translate.c | 1 -
target/sparc/translate.c | 1 -
target/xtensa/translate.c | 1 -
17 files changed, 17 deletions(-)
diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index f454adea5e0..5fcedd85d36 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -28,7 +28,6 @@
#include "exec/cpu_ldst.h"
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
-#include "trace-tcg.h"
#include "exec/translator.h"
#include "exec/log.h"
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 7f74d0e81a9..066d942b7fc 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -35,7 +35,6 @@
#include "exec/helper-gen.h"
#include "exec/log.h"
-#include "trace-tcg.h"
#include "translate-a64.h"
#include "qemu/atomic128.h"
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 46210eb696d..35d838aa068 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -30,7 +30,6 @@
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
#include "exec/log.h"
-#include "trace-tcg.h"
#include "translate-a64.h"
#include "fpu/softfloat.h"
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 9e2cca77077..3a3ccc97eb6 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -34,7 +34,6 @@
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
-#include "trace-tcg.h"
#include "exec/log.h"
diff --git a/target/cris/translate.c b/target/cris/translate.c
index 6dd5a267a61..044e587eeb2 100644
--- a/target/cris/translate.c
+++ b/target/cris/translate.c
@@ -37,7 +37,6 @@
#include "exec/helper-gen.h"
-#include "trace-tcg.h"
#include "exec/log.h"
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 64af1e0d5cc..424ec3252ed 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -27,7 +27,6 @@
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
#include "exec/translator.h"
-#include "trace-tcg.h"
#include "exec/log.h"
/* Since we have a distinction between register size and address size,
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index a7f5c0c8f20..5fb3350c5a8 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -30,7 +30,6 @@
#include "exec/helper-gen.h"
#include "helper-tcg.h"
-#include "trace-tcg.h"
#include "exec/log.h"
#define PREFIX_REPZ 0x01
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index f0c5bf9154e..348fc6e844e 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -31,7 +31,6 @@
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
-#include "trace-tcg.h"
#include "exec/log.h"
#include "fpu/softfloat.h"
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index c1b13f4c7d3..5dfb08d49f1 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -29,7 +29,6 @@
#include "exec/translator.h"
#include "qemu/qemu-print.h"
-#include "trace-tcg.h"
#include "exec/log.h"
#define EXTRACT_FIELD(src, start, end) \
diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c
index 797eba44347..9895f7336c6 100644
--- a/target/mips/tcg/translate.c
+++ b/target/mips/tcg/translate.c
@@ -32,7 +32,6 @@
#include "semihosting/semihost.h"
#include "target/mips/trace.h"
-#include "trace-tcg.h"
#include "exec/translator.h"
#include "exec/log.h"
#include "qemu/qemu-print.h"
diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c
index a9c81f8bd5b..5db63d76093 100644
--- a/target/openrisc/translate.c
+++ b/target/openrisc/translate.c
@@ -33,7 +33,6 @@
#include "exec/helper-gen.h"
#include "exec/gen-icount.h"
-#include "trace-tcg.h"
#include "exec/log.h"
/* is_jmp field values */
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index f65d1e81eac..07d79acc08f 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -32,7 +32,6 @@
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
-#include "trace-tcg.h"
#include "exec/translator.h"
#include "exec/log.h"
#include "qemu/atomic128.h"
diff --git a/target/rx/translate.c b/target/rx/translate.c
index 9ea941c6302..22a15ee11d8 100644
--- a/target/rx/translate.c
+++ b/target/rx/translate.c
@@ -26,7 +26,6 @@
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
#include "exec/translator.h"
-#include "trace-tcg.h"
#include "exec/log.h"
typedef struct DisasContext {
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index e243624d2a6..d7c7f37e363 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -42,7 +42,6 @@
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
-#include "trace-tcg.h"
#include "exec/translator.h"
#include "exec/log.h"
#include "qemu/atomic128.h"
diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index 93127906237..1096817ee79 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -28,7 +28,6 @@
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
#include "exec/translator.h"
-#include "trace-tcg.h"
#include "exec/log.h"
#include "qemu/qemu-print.h"
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index 4bfa3179f8e..f3fe7a03699 100644
--- a/target/sparc/translate.c
+++ b/target/sparc/translate.c
@@ -29,7 +29,6 @@
#include "exec/helper-gen.h"
-#include "trace-tcg.h"
#include "exec/translator.h"
#include "exec/log.h"
#include "asi.h"
diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 14028d307d8..d5da35f4fcd 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -43,7 +43,6 @@
#include "exec/helper-proto.h"
#include "exec/helper-gen.h"
-#include "trace-tcg.h"
#include "exec/log.h"
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tcg: Avoid including 'trace-tcg.h' in target translate.c
2021-06-22 16:15 [PATCH] tcg: Avoid including 'trace-tcg.h' in target translate.c Philippe Mathieu-Daudé
@ 2021-06-22 17:50 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2021-06-22 17:50 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Peter Maydell, Aleksandar Rikalo, Eduardo Habkost, Yoshinori Sato,
David Hildenbrand, Cornelia Huck, Mark Cave-Ayland,
Laurent Vivier, Greg Kurz, Max Filippov, qemu-s390x, qemu-arm,
qemu-ppc, Aurelien Jarno, Edgar E. Iglesias, Thomas Huth,
Paolo Bonzini, Stafford Horne, Artyom Tarasenko, David Gibson
On 6/22/21 9:15 AM, Philippe Mathieu-Daudé wrote:
> The root trace-events only declares a single TCG event:
>
> $ git grep -w tcg trace-events
> trace-events:115:# tcg/tcg-op.c
> trace-events:137:vcpu tcg guest_mem_before(TCGv vaddr, uint16_t info) "info=%d", "vaddr=0x%016"PRIx64" info=%d"
>
> and only a tcg/tcg-op.c uses it:
>
> $ git grep -l trace_guest_mem_before_tcg
> tcg/tcg-op.c
>
> therefore it is pointless to include "trace-tcg.h" in each target
> (because it is not used). Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
Thanks, queued.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-22 17:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-22 16:15 [PATCH] tcg: Avoid including 'trace-tcg.h' in target translate.c Philippe Mathieu-Daudé
2021-06-22 17:50 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).