From: Eric Blake <eblake@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment
Date: Wed, 10 Jan 2018 09:08:16 -0600 [thread overview]
Message-ID: <0e741e13-1922-17ff-ec18-d3efa39805d7@redhat.com> (raw)
In-Reply-To: <20180110150413.GE2450@work-vm>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
On 01/10/2018 09:04 AM, Dr. David Alan Gilbert wrote:
> * Dr. David Alan Gilbert (dgilbert@redhat.com) wrote:
>> * Paolo Bonzini (pbonzini@redhat.com) wrote:
>>> These are basically David's patches, with a couple changes for clarity
>>> and robustness.
>>
>> Yes, those look fine to me.
>> (Patchew seems to be annoyed at the Tracing - I can't see why)
>
> Stefan has explained this to me; we need to remove the spaces after the
> PRIx64 macro calls in the first patch.
> +find_ram_offset_loop(uint64_t size, uint64_t candidate, uint64_t offset, uint64_t next, uint64_t mingap) "trying size: 0x%"PRIx64 " @ 0x%"PRIx64 ," offset: 0x%"PRIx64" next: 0x%"PRIx64 " mingap: 0x%"PRIx64
You have a misplaced ','; s/," offset/", offset/
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-01-10 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 14:25 [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment Paolo Bonzini
2018-01-10 14:25 ` [Qemu-devel] [PATCH 1/2] find_ram_offset: Add comments and tracing Paolo Bonzini
2018-01-10 14:25 ` [Qemu-devel] [PATCH 2/2] find_ram_offset: Align ram_addr_t allocation on long boundaries Paolo Bonzini
2018-01-10 14:31 ` [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment no-reply
2018-01-10 14:32 ` no-reply
2018-01-10 14:37 ` Dr. David Alan Gilbert
2018-01-10 15:04 ` Dr. David Alan Gilbert
2018-01-10 15:08 ` Eric Blake [this message]
2018-01-10 14:44 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e741e13-1922-17ff-ec18-d3efa39805d7@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).