Re: [PATCH] tests/avocado: Allow running user-mode tests

[Thomas Huth <thuth@redhat.com>]

On 21/08/2024 17.38, Philippe Mathieu-Daudé wrote:
> Commit 816d4201ea ("tests/avocado: Move LinuxTest related
> code into a separate file") removed the Avocado 'process'
> import which is used by the QemuUserTest class, restore it.
> 
> Fixes: 816d4201ea ("tests/avocado: Move LinuxTest ...")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Unfortunately the single linux-user test is not run on CI,
> and I haven't ran it manually since too long...:
> https://gitlab.com/qemu-project/qemu/-/issues/2525
> ---
>   tests/avocado/avocado_qemu/__init__.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado_qemu/__init__.py
> index ef935614cf..0d57addfea 100644
> --- a/tests/avocado/avocado_qemu/__init__.py
> +++ b/tests/avocado/avocado_qemu/__init__.py
> @@ -17,7 +17,7 @@
>   import uuid
>   
>   import avocado
> -from avocado.utils import ssh
> +from avocado.utils import process, ssh
>   from avocado.utils.path import find_command

Reviewed-by: Thomas Huth <thuth@redhat.com>

... but is the test itself still working for you? When I run it, I get:

  ...
  (074/281) 
tests/avocado/linux_ssh_mips_malta.py:LinuxSSH.test_mips_malta64eb_kernel3_2_0: 
SKIP: Test might timeout
  (075/281) 
tests/avocado/linux_ssh_mips_malta.py:LinuxSSH.test_mips_malta64el_kernel3_2_0: 
SKIP: Test might timeout
  (076/281) tests/avocado/load_bflt.py:LoadBFLT.test_stm32: ERROR: Command 
'./qemu-arm  /bin/busybox ' failed.\nstdout: b''\nstderr: 
b''\nadditional_info: None (0.06 s)
Interrupting job (failfast).

Seem like self.workdir is not set here??

  Thomas