Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

On 06/02/2017 08:54 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> Finally, are you OK with my wording? If I reroll, can I add your r-b?
>> What final wording are you proposing (full paragraph, not a snippet)?
> 
> 2. _sync suffix
>    _sync is related to the fact that nbd_wr_syncv doesn't return if

s/if/if a/

>    write to socket returns EAGAIN. In first implementation nbd_wr_syncv

s/In first implementation/The first implementation of/

>    (was wr_sync in 7a5ca8648b) just loops while getting EAGAIN, current

s/current/the current/

>    implementation yields in this case.
>    Why to get rid of it:

maybe: s/Why/Why we want/

>    - it is normal for r/w functions to be synchronous, so having

s/having/having an/

>      additional suffix for it looks redundant (contrariwise, we have
>      _aio suffix for async functions)
>    - _sync suffix in block layer is used when function does flush (so
>      using it for other thing is confusing a bit)
>    - keep function names short after adding nbd_ prefix

Thanks for bearing with me, and letting me help on the grammar subtleties.

>>
>>>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> At any rate, I already gave R-b for the code, so finessing the commit
>> message doesn't change that if the code remains unchanged.
>>
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]