From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Pranith Kumar" <bobby.prani@gmail.com>
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>,
"open list:Overall" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] tcg: handle EXCP_ATOMIC exception properly
Date: Fri, 10 Feb 2017 13:15:19 +0100 [thread overview]
Message-ID: <0ec07664-fa06-8f09-33ce-ca15448c7851@redhat.com> (raw)
In-Reply-To: <871sv6xmzk.fsf@linaro.org>
On 10/02/2017 13:13, Alex Bennée wrote:
>> + if (atomic_read(&other_cpu->running) &&
>> !qemu_cpu_is_self(other_cpu)) {
> The comment above reads:
>
> Must only be called from outside cpu_exec.
>
> So we need to revise this comment. Is this really a limitation or was it
> originally the design goal?
If you want to call it within cpu_exec, you can always use
cpu_exec_end/start around it.
I think we should first of all get rid of the iothread lock within
cpu_exec, and then look at this patch again.
Paolo
next prev parent reply other threads:[~2017-02-10 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 1:45 [Qemu-devel] [PATCH] tcg: handle EXCP_ATOMIC exception properly Pranith Kumar
2017-02-10 4:54 ` Pranith Kumar
2017-02-10 11:34 ` Paolo Bonzini
2017-02-10 12:18 ` Alex Bennée
2017-02-10 12:29 ` Paolo Bonzini
2017-02-10 12:57 ` Alex Bennée
2017-02-10 13:59 ` Pranith Kumar
2017-02-10 12:13 ` Alex Bennée
2017-02-10 12:15 ` Paolo Bonzini [this message]
2017-02-10 12:33 ` Alex Bennée
2017-02-10 13:12 ` Paolo Bonzini
2017-02-10 14:37 ` Alex Bennée
2017-02-10 14:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ec07664-fa06-8f09-33ce-ca15448c7851@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bobby.prani@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).