qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Zhang, Chen" <chen.zhang@intel.com>
To: Lukas Straub <lukasstraub2@web.de>, qemu-devel <qemu-devel@nongnu.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Li Zhijian" <lizhijian@cn.fujitsu.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: RE: [PATCH 2/3] chardev/char.c: Use qemu_co_sleep_ns if in coroutine
Date: Wed, 22 Apr 2020 08:31:19 +0000	[thread overview]
Message-ID: <0ec3fe8fb159493fa7f08bf7484116a0@intel.com> (raw)
In-Reply-To: <f231c9abc706f5825e41c0fbaa4fc82de1121435.1586370737.git.lukasstraub2@web.de>



> -----Original Message-----
> From: Lukas Straub <lukasstraub2@web.de>
> Sent: Thursday, April 9, 2020 2:34 AM
> To: qemu-devel <qemu-devel@nongnu.org>
> Cc: Zhang, Chen <chen.zhang@intel.com>; Li Zhijian
> <lizhijian@cn.fujitsu.com>; Jason Wang <jasowang@redhat.com>; Marc-
> André Lureau <marcandre.lureau@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>
> Subject: [PATCH 2/3] chardev/char.c: Use qemu_co_sleep_ns if in coroutine
> 
> This will be needed in the next patch.
> 
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>


Reviewed-by: Zhang Chen <chen.zhang@intel.com>

> ---
>  chardev/char.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/chardev/char.c b/chardev/char.c index 04075389bf..51ad0dc6b3
> 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -38,6 +38,7 @@
>  #include "qemu/module.h"
>  #include "qemu/option.h"
>  #include "qemu/id.h"
> +#include "qemu/coroutine.h"
> 
>  #include "chardev/char-mux.h"
> 
> @@ -119,7 +120,11 @@ static int qemu_chr_write_buffer(Chardev *s,
>      retry:
>          res = cc->chr_write(s, buf + *offset, len - *offset);
>          if (res < 0 && errno == EAGAIN && write_all) {
> -            g_usleep(100);
> +            if (qemu_in_coroutine()) {
> +                qemu_co_sleep_ns(QEMU_CLOCK_REALTIME, 100000);
> +            } else {
> +                g_usleep(100);
> +            }
>              goto retry;
>          }
> 
> --
> 2.20.1



  parent reply	other threads:[~2020-04-22  8:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 18:33 [PATCH 0/3] colo-compare bugfixes Lukas Straub
2020-04-08 18:33 ` [PATCH 1/3] net/colo-compare.c: Create event_bh with the right AioContext Lukas Straub
2020-04-22  8:29   ` Zhang, Chen
2020-04-22  8:43     ` Lukas Straub
2020-04-22  9:03       ` Zhang, Chen
2020-04-22  9:40         ` Lukas Straub
2020-04-23  7:29           ` Zhang, Chen
2020-04-24  4:36             ` Derek Su
2020-04-27  3:09               ` Zhang, Chen
2020-04-08 18:33 ` [PATCH 2/3] chardev/char.c: Use qemu_co_sleep_ns if in coroutine Lukas Straub
2020-04-08 19:10   ` Marc-André Lureau
2020-04-22  8:31   ` Zhang, Chen [this message]
2020-04-08 18:33 ` [PATCH 3/3] net/colo-compare.c: Fix deadlock Lukas Straub
2020-04-22  8:40   ` Zhang, Chen
2020-04-23 14:03     ` Lukas Straub

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ec3fe8fb159493fa7f08bf7484116a0@intel.com \
    --to=chen.zhang@intel.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=lukasstraub2@web.de \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).