From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciJiF-0001ed-BO for qemu-devel@nongnu.org; Mon, 27 Feb 2017 06:43:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciJiC-0007Tk-7n for qemu-devel@nongnu.org; Mon, 27 Feb 2017 06:43:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57788) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ciJiC-0007T7-1U for qemu-devel@nongnu.org; Mon, 27 Feb 2017 06:43:28 -0500 References: <1485333658-23035-1-git-send-email-thuth@redhat.com> From: Thomas Huth Message-ID: <0eca8185-8e94-46f8-6b7a-36c4a21bc28d@redhat.com> Date: Mon, 27 Feb 2017 12:43:23 +0100 MIME-Version: 1.0 In-Reply-To: <1485333658-23035-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] null-machine: Add support for the "-kernel" parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Eduardo Habkost , Marcel Apfelbaum Cc: Max Filippov , Laurent Vivier , Alistair Francis On 25.01.2017 09:40, Thomas Huth wrote: > We can have basic support for the "-kernel" parameter quite easily > by using the generic loader device. This should be enough for most > boards which do not need special machine-specific magic for loading > a kernel (and for those that need special magic, the generic "none" > machine is likely not suitable for using it as an instruction set > simulator board anyway). > > Signed-off-by: Thomas Huth > --- > PS: If we can't agree on using the generic loader here, I can also > prepare a patch instead that simply prints out an error message > if the user tried to use the "-kernel" parameter. > > hw/core/null-machine.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c > index 27c8369..866e699 100644 > --- a/hw/core/null-machine.c > +++ b/hw/core/null-machine.c > @@ -5,6 +5,7 @@ > * > * Authors: > * Anthony Liguori > + * Thomas Huth > * > * This work is licensed under the terms of the GNU GPL, version 2 or later. > * See the COPYING file in the top-level directory. > @@ -16,6 +17,7 @@ > #include "qemu/error-report.h" > #include "hw/hw.h" > #include "hw/boards.h" > +#include "hw/core/generic-loader.h" > #include "sysemu/sysemu.h" > #include "exec/address-spaces.h" > #include "cpu.h" > @@ -40,6 +42,18 @@ static void machine_none_init(MachineState *mch) > memory_region_allocate_system_memory(ram, NULL, "ram", mch->ram_size); > memory_region_add_subregion(get_system_memory(), 0, ram); > } > + > + /* Load kernel */ > + if (mch->kernel_filename) { > + DeviceState *loader; > + > + loader = qdev_create(sysbus_get_default(), TYPE_GENERIC_LOADER); > + qdev_prop_set_string(loader, "file", mch->kernel_filename); > + if (cpu) { > + qdev_prop_set_uint32(loader, "cpu-num", cpu->cpu_index); > + } > + qdev_init_nofail(loader); > + } > } > > static void machine_none_machine_init(MachineClass *mc) *ping* Apparently the discussion has ceased ... can we get a consensus whether we want to support the "-kernel" parameter for the "none" machine or not? Thomas