From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Claudio Fontana <cfontana@suse.de>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 2/2] hw/core: Move hw_error() out of cpus.c
Date: Wed, 2 Sep 2020 18:02:46 +0200 [thread overview]
Message-ID: <0ed6327b-9966-3704-2a56-471a72b4c282@redhat.com> (raw)
In-Reply-To: <514f8742-e817-556f-0029-ba0ef9ac5509@amsat.org>
On 02/09/2020 17.59, Philippe Mathieu-Daudé wrote:
> On 9/2/20 5:38 PM, Richard Henderson wrote:
>> On 9/1/20 11:37 PM, Thomas Huth wrote:
>>> - Move the function as "static inline" into the header file
>>> instead - it's not so big, so an inline function should be
>>> ok here.
>>
>> stdarg and inline do not mix.
>>
>>> - Add a big fat warning comment to the header that this
>>> function should not be used for new code anymore.
>>
>> But certainly this.
>
> Will do, but this has been proven to not work well...
... or add a warning to checkpatch.pl ?
Thomas
next prev parent reply other threads:[~2020-09-02 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 11:23 [PATCH 0/2] hw/core: Move hw_error() out of cpus.c Philippe Mathieu-Daudé
2020-09-01 11:23 ` [PATCH 1/2] cpus: Do not dump CPU state when calling hw_error() Philippe Mathieu-Daudé
2020-09-02 6:33 ` Thomas Huth
2020-09-02 16:04 ` Philippe Mathieu-Daudé
2020-09-01 11:23 ` [PATCH 2/2] hw/core: Move hw_error() out of cpus.c Philippe Mathieu-Daudé
2020-09-02 6:37 ` Thomas Huth
2020-09-02 15:38 ` Richard Henderson
2020-09-02 15:59 ` Philippe Mathieu-Daudé
2020-09-02 16:02 ` Thomas Huth [this message]
2020-09-02 16:13 ` Philippe Mathieu-Daudé
2020-09-01 16:44 ` [PATCH 0/2] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ed6327b-9966-3704-2a56-471a72b4c282@redhat.com \
--to=thuth@redhat.com \
--cc=cfontana@suse.de \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).