From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: berto@igalia.com, mreitz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 9/9] quorum: Clean up quorum_aio_get()
Date: Tue, 22 Nov 2016 06:54:07 -0600 [thread overview]
Message-ID: <0ee2e7ac-73cb-ca45-fb90-06da6763b4d9@redhat.com> (raw)
In-Reply-To: <1479817444-6880-10-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On 11/22/2016 06:24 AM, Kevin Wolf wrote:
> Make sure that all fields of the new QuorumAIOCB are zeroed when the
> function returns even without explicitly setting them. This will protect
> us when new fields are added, removes some explicit zero assignment and
> makes the code a little nicer to read.
>
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/quorum.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-11-22 12:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 12:23 [Qemu-devel] [PATCH v2 0/9] quorum: Implement .bdrv_co_preadv/pwritev() Kevin Wolf
2016-11-22 12:23 ` [Qemu-devel] [PATCH v2 1/9] coroutine: Introduce qemu_coroutine_enter_if_inactive() Kevin Wolf
2016-11-22 12:23 ` [Qemu-devel] [PATCH v2 2/9] quorum: Remove s from quorum_aio_get() arguments Kevin Wolf
2016-11-22 12:23 ` [Qemu-devel] [PATCH v2 3/9] quorum: Implement .bdrv_co_readv/writev Kevin Wolf
2016-11-22 12:23 ` [Qemu-devel] [PATCH v2 4/9] quorum: Do cleanup in caller coroutine Kevin Wolf
2016-11-22 12:24 ` [Qemu-devel] [PATCH v2 5/9] quorum: Inline quorum_aio_cb() Kevin Wolf
2016-11-29 9:39 ` Paolo Bonzini
2016-11-29 10:06 ` Alberto Garcia
2016-11-29 13:38 ` Kevin Wolf
2016-11-22 12:24 ` [Qemu-devel] [PATCH v2 6/9] quorum: Avoid bdrv_aio_writev() for rewrites Kevin Wolf
2016-11-22 12:24 ` [Qemu-devel] [PATCH v2 7/9] quorum: Implement .bdrv_co_preadv/pwritev() Kevin Wolf
2016-11-22 12:52 ` Eric Blake
2016-11-22 13:18 ` Alberto Garcia
2016-11-22 12:24 ` [Qemu-devel] [PATCH v2 8/9] quorum: Inline quorum_fifo_aio_cb() Kevin Wolf
2016-11-29 9:41 ` Paolo Bonzini
2016-11-22 12:24 ` [Qemu-devel] [PATCH v2 9/9] quorum: Clean up quorum_aio_get() Kevin Wolf
2016-11-22 12:54 ` Eric Blake [this message]
2016-11-22 13:25 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ee2e7ac-73cb-ca45-fb90-06da6763b4d9@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).