From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE08C2D0A3 for ; Tue, 10 Nov 2020 01:51:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40073206A4 for ; Tue, 10 Nov 2020 01:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40073206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcIoF-0000Ls-5d for qemu-devel@archiver.kernel.org; Mon, 09 Nov 2020 20:50:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcInG-0008Fo-Kt for qemu-devel@nongnu.org; Mon, 09 Nov 2020 20:49:59 -0500 Received: from mga09.intel.com ([134.134.136.24]:18211) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcInE-0002mG-4x for qemu-devel@nongnu.org; Mon, 09 Nov 2020 20:49:57 -0500 IronPort-SDR: gSh6nA8vHEMlJAoLFEtU2dGIqQEhoUvH6RkAWGaf7wcnUD7mIk8jspXhnPTe+OgxY1XOmEg5XR NkMuGfwztJGQ== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="170052841" X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="170052841" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 17:49:53 -0800 IronPort-SDR: iLWfhVeJPwdl5kuGCq5+cXXPjDRZ9x4YsAf2jLwQG0BcO3surBEqJqnh3wHuvDDNi9n2w1eBHV V2yd4E+7dGQA== X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="541126259" Received: from likexu-mobl1.ccr.corp.intel.com (HELO [10.238.4.107]) ([10.238.4.107]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 17:49:51 -0800 Subject: Re: [PATCH 4/5 v4] KVM: VMX: Fill in conforming vmx_x86_ops via macro To: Krish Sadhukhan , kvm@vger.kernel.org References: <20201110012312.20820-1-krish.sadhukhan@oracle.com> <20201110012312.20820-5-krish.sadhukhan@oracle.com> From: Like Xu Organization: Intel OTC Message-ID: <0ef40499-77b8-587a-138d-9b612ae9ae8c@linux.intel.com> Date: Tue, 10 Nov 2020 09:49:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: <20201110012312.20820-5-krish.sadhukhan@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=134.134.136.24; envelope-from=like.xu@linux.intel.com; helo=mga09.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 20:49:53 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, vkuznets@redhat.com, qemu-devel@nongnu.org, sean.j.christopherson@intel.com, jmattson@google.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Krish, On 2020/11/10 9:23, Krish Sadhukhan wrote: > @@ -1192,7 +1192,7 @@ void vmx_set_host_fs_gs(struct vmcs_host_state *host, u16 fs_sel, u16 gs_sel, > } > } > > -void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu) > +void vmx_prepare_guest_switch(struct kvm_vcpu *vcpu) What do you think of renaming it to void vmx_prepare_switch_for_guest(struct kvm_vcpu *vcpu)； ? Thanks, Like Xu > { > struct vcpu_vmx *vmx = to_vmx(vcpu); > struct vmcs_host_state *host_state; > > @@ -311,7 +311,7 @@ void vmx_vcpu_load_vmcs(struct kvm_vcpu *vcpu, int cpu, > int allocate_vpid(void); > void free_vpid(int vpid); > void vmx_set_constant_host_state(struct vcpu_vmx *vmx); > -void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu); > +void vmx_prepare_guest_switch(struct kvm_vcpu *vcpu); > void vmx_set_host_fs_gs(struct vmcs_host_state *host, u16 fs_sel, u16 gs_sel, > unsigned long fs_base, unsigned long gs_base); > int vmx_get_cpl(struct kvm_vcpu *vcpu);