qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: jejb@linux.ibm.com, qemu-devel@nongnu.org
Cc: ashish.kalra@amd.com, brijesh.singh@amd.com,
	david.kaplan@amd.com, jon.grimm@amd.com, tobin@ibm.com,
	frankeh@us.ibm.com,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com,
	pbonzini@redhat.com, berrange@redhat.com,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 3/3] sev: update sev-inject-launch-secret to make gpa optional
Date: Fri, 11 Dec 2020 16:54:59 -0600	[thread overview]
Message-ID: <0ef7d374-e284-4b11-3b10-301609f3495e@amd.com> (raw)
In-Reply-To: <aa8ebbb5b14821bcaf1d599511f75060d9dcc460.camel@linux.ibm.com>

On 12/11/20 4:45 PM, James Bottomley wrote:
> On Fri, 2020-12-11 at 16:00 -0600, Tom Lendacky wrote:
>> On 12/9/20 11:23 AM, James Bottomley wrote:
> 
> So for this one I'm not checking the length, which argues it wouldn't
> be subject to the added length new data rule and I'd have to use a new
> guid for new information.  However, I could also see situations where
> you would check the length and thus would have the ability to add
> fields (either at the beginning or the end).

I think this paragraph explains it nicely and a slightly expanded comment 
with this information would be enough.

Thanks,
Tom


> 
>> Whatever we decide should probably be documented in both the OVMF
>> patches and the Qemu patches.
> 
> OK, I can add a comment about my use case and you can add one
> documenting your length based use case.
> 
> James
> 
> 


  reply	other threads:[~2020-12-11 23:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 17:23 [PATCH 0/3] sev: enable seret injection to a self described area in OVMF James Bottomley
2020-12-09 17:23 ` [PATCH 1/3] sev: add sev-inject-launch-secret James Bottomley
2020-12-09 17:23 ` [PATCH 2/3] pc: add parser for OVMF reset block James Bottomley
2020-12-09 17:23 ` [PATCH 3/3] sev: update sev-inject-launch-secret to make gpa optional James Bottomley
2020-12-11 22:00   ` Tom Lendacky
2020-12-11 22:45     ` James Bottomley
2020-12-11 22:54       ` Tom Lendacky [this message]
2020-12-14 14:14         ` Laszlo Ersek
2020-12-09 17:52 ` [PATCH 0/3] sev: enable seret injection to a self described area in OVMF James Bottomley
2020-12-09 19:33 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ef7d374-e284-4b11-3b10-301609f3495e@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=Dov.Murik1@il.ibm.com \
    --cc=ashish.kalra@amd.com \
    --cc=berrange@redhat.com \
    --cc=brijesh.singh@amd.com \
    --cc=david.kaplan@amd.com \
    --cc=dgilbert@redhat.com \
    --cc=dovmurik@linux.vnet.ibm.com \
    --cc=frankeh@us.ibm.com \
    --cc=jejb@linux.ibm.com \
    --cc=jon.grimm@amd.com \
    --cc=lersek@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tobin@ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).