From: Richard Henderson <richard.henderson@linaro.org>
To: chengang@emindsoft.com.cn, ehabkost@redhat.com,
marcel.apfelbaum@gmail.com, laurent@vivier.eu
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] linux-user: i386: Use trapnr which returns from cpu_exec() instead of exception_index
Date: Sun, 27 Sep 2020 10:54:23 -0700 [thread overview]
Message-ID: <0ef9553e-94fe-56fa-8c17-728741afcd9a@linaro.org> (raw)
In-Reply-To: <20200926103956.28199-1-chengang@emindsoft.com.cn>
On 9/26/20 3:39 AM, chengang@emindsoft.com.cn wrote:
> +++ b/include/hw/core/cpu.h
> @@ -458,6 +458,8 @@ struct CPUState {
>
> /* track IOMMUs whose translations we've cached in the TCG TLB */
> GArray *iommu_notifiers;
> +
> + int trapnr;
Don't put this here. It belongs in CPUX86State, possibly with #ifdef
CONFIG_USER_ONLY.
> void cpu_loop(CPUX86State *env)
> {
> CPUState *cs = env_cpu(env);
> - int trapnr;
Why are you removing the local variable?
r~
prev parent reply other threads:[~2020-09-27 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 10:39 [PATCH] linux-user: i386: Use trapnr which returns from cpu_exec() instead of exception_index chengang
2020-09-27 17:54 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ef9553e-94fe-56fa-8c17-728741afcd9a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=chengang@emindsoft.com.cn \
--cc=ehabkost@redhat.com \
--cc=laurent@vivier.eu \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).