From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>
Subject: Re: [PATCH] qapi: Make some ObjectTypes depend on the build settings
Date: Tue, 5 Oct 2021 08:49:09 +0200 [thread overview]
Message-ID: <0f17d6c3-73b4-2267-f677-a7156861b3e1@redhat.com> (raw)
In-Reply-To: <875yujzk10.fsf@dusky.pond.sub.org>
On 29/09/2021 13.41, Markus Armbruster wrote:
[...]
> In my opinion, use of CONFIG_FOO in QAPI schemata is no worse than using
> them in C type definitions.
>
> In both cases, we have a choice: compile out stuff this build doesn't
> need with compile-time conditionals, or leave it in unused.
>
> In C, we sometimes have to compile out stuff, say when it depends on
> headers we don't have.
>
> In QAPI, we sometimes want to compile out stuff to make introspection
> more useful. This can be a killer argument.
So what's your opinion on this patch here? Good to go? Needs a rework? Or
should I simply forget about it?
Thomas
next prev parent reply other threads:[~2021-10-05 6:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 16:02 [PATCH] qapi: Make some ObjectTypes depend on the build settings Thomas Huth
2021-09-28 17:39 ` Philippe Mathieu-Daudé
2021-09-29 6:17 ` Thomas Huth
2021-09-29 11:41 ` Markus Armbruster
2021-10-05 6:49 ` Thomas Huth [this message]
2021-10-05 8:24 ` Markus Armbruster
2021-10-08 12:01 ` Markus Armbruster
2021-10-08 17:13 ` Paolo Bonzini
2021-10-09 12:51 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f17d6c3-73b4-2267-f677-a7156861b3e1@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).