From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3686CEB64D7 for ; Tue, 20 Jun 2023 11:39:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBZhK-0002Md-9h; Tue, 20 Jun 2023 07:38:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBZhF-0002K6-RV; Tue, 20 Jun 2023 07:38:55 -0400 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3] helo=gandalf.ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBZhD-0003Dk-Fw; Tue, 20 Jun 2023 07:38:53 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4Qll5J61ZHz4wjC; Tue, 20 Jun 2023 21:38:44 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Qll5F309Gz4wjF; Tue, 20 Jun 2023 21:38:41 +1000 (AEST) Message-ID: <0f1a63fe-7a10-9e4c-cadb-6bb9e06cfa2d@kaod.org> Date: Tue, 20 Jun 2023 13:38:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [SPAM] Re: [PATCH 8/9] ppc/pnv: Rephrase error when run with KVM Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Thomas Huth , Richard Henderson , Paolo Bonzini , Markus Armbruster Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Daniel Henrique Barboza , Fabiano Rosas , Claudio Fontana References: <20230620055911.187065-1-clg@kaod.org> <20230620055911.187065-9-clg@kaod.org> <4e6420d8-a39f-a093-b115-f1a107031ec2@linaro.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <4e6420d8-a39f-a093-b115-f1a107031ec2@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=SRS0=rj0j=CI=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/20/23 13:31, Philippe Mathieu-Daudé wrote: > On 20/6/23 07:59, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater >> --- >>   hw/ppc/pnv.c | 3 ++- >>   1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c >> index 590fc64b32e9..fc083173f346 100644 >> --- a/hw/ppc/pnv.c >> +++ b/hw/ppc/pnv.c >> @@ -799,7 +799,8 @@ static void pnv_init(MachineState *machine) >>       DeviceState *dev; >>       if (kvm_enabled()) { >> -        error_report("The powernv machine does not work with KVM acceleration"); >> +        error_report("machine %s does not support the KVM accelerator", >> +                     mc->name); >>           exit(EXIT_FAILURE); >>       } > > Reviewed-by: Philippe Mathieu-Daudé > > Now thinking loudly, we could have an array of allowed accelerators > in MachineClass, similarly to allowed_dynamic_sysbus_devices[], then > handle this generically. I agree. I had something like that in mind as a followup. C.