Re: [PATCH v3 2/4] target/ppc: divided mmu_helper.c in 2 files

[Richard Henderson <richard.henderson@linaro.org>]

On 7/8/21 9:49 AM, Lucas Mateus Castro (alqotel) wrote:
> +++ b/target/ppc/cpu.h
> @@ -1327,6 +1327,26 @@ void store_40x_dbcr0(CPUPPCState *env, uint32_t val);
>   void store_40x_sler(CPUPPCState *env, uint32_t val);
>   void store_booke_tcr(CPUPPCState *env, target_ulong val);
>   void store_booke_tsr(CPUPPCState *env, target_ulong val);
> +typedef struct mmu_ctx_t mmu_ctx_t;
> +bool ppc_xlate(PowerPCCPU *cpu, vaddr eaddr, MMUAccessType access_type,
> +                      hwaddr *raddrp, int *psizep, int *protp,
> +                      int mmu_idx, bool guest_visible);
> +int ppcmas_tlb_check(CPUPPCState *env, ppcmas_tlb_t *tlb,
> +                            hwaddr *raddrp, target_ulong address,
> +                            uint32_t pid);
> +int ppcemb_tlb_check(CPUPPCState *env, ppcemb_tlb_t *tlb,
> +                            hwaddr *raddrp,
> +                            target_ulong address, uint32_t pid, int ext,
> +                            int i);
> +int get_physical_address_wtlb(CPUPPCState *env, mmu_ctx_t *ctx,
> +                                     target_ulong eaddr,
> +                                     MMUAccessType access_type, int type,
> +                                     int mmu_idx);
> +hwaddr booke206_tlb_to_page_size(CPUPPCState *env,
> +                                        ppcmas_tlb_t *tlb);
> +/* Software driven TLB helpers */
> +int ppc6xx_tlb_getnum(CPUPPCState *env, target_ulong eaddr,
> +                                    int way, int is_code);

Why are any of these going into cpu.h?
Surely they are not used outside of target/ppc/.


r~