From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhE8s-0001sb-FW for qemu-devel@nongnu.org; Mon, 14 Aug 2017 08:06:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhE8p-0007lC-QO for qemu-devel@nongnu.org; Mon, 14 Aug 2017 08:06:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38592) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhE8p-0007jX-I0 for qemu-devel@nongnu.org; Mon, 14 Aug 2017 08:06:43 -0400 References: <87r2wez7b5.fsf@dusky.pond.sub.org> From: Jason Wang Message-ID: <0f24d952-665d-cfcd-00ca-7b5a207a05e2@redhat.com> Date: Mon, 14 Aug 2017 20:06:35 +0800 MIME-Version: 1.0 In-Reply-To: <87r2wez7b5.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v8 0/4] Improve error reporting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Mao Zhongyi Cc: qemu-devel@nongnu.org, kraxel@redhat.com, pbonzini@redhat.com On 2017=E5=B9=B408=E6=9C=8814=E6=97=A5 20:02, Markus Armbruster wrote: > Jason, did this fall through the cracks? Unfortunately yes, consider it's rc3, I've queued this for 2.11. Thanks > > Mao Zhongyi writes: > >> v8: >> * PATCH 02 & 04 >> -resetting the error message for the user to read. [Markus Armbru= ster] >> -fix the indentation and commit message. [Markus Armbruster] >> =20 >> v7: >> * PATCH 01 >> -fix the error message. [Daniel P. Berrange] >> -adjust the indentation problem. [Eric Blake] >> * PATCH 03 >> -print a generic message when gethostbyname() failed in parse_host_= port(), >> drop the misleading ": unkonwn host" part. [Markus Armbruster] >> >> v6: >> * PATCH 02 >> -rename the subject >> -drop the "qemu: error: " prefix. >> -correct inappropriate error information settings. >> * PATCH 03,04 >> -correct inappropriate error information settings. [Markus Armbr= uster] >> >> v5: >> * PATCH 01 make the commit message more exact about the actual functio= n. [Markus Armbruster] >> * PATCH 02, 03, 04 still retains the original function, but specific >> content and order of each patch has been adjusted substant= ially, >> so that ensure each patch is a completed fix. [Markus A= rmbruster] >> >> v4: >> * PATCH 01 is redoing previous patch 1, replace the fprintf() with err= or_report() >> in the 'default' case of net_socket_fd_init() [Markus Armbruste= r] >> >> v3: >> * PATCH 01 is suggested by Markus and Daniel that removes the dubious = 'default' case >> in the net_socket_fd_init(). Jason agreed. >> * PATCH 02 is redoing previous patch 4. >> * PATCH 04 is redoing previous patch 2, improves sort of error message= s. >> >> v2: >> * PATCH 02 reworking of patch 2 following Markus's suggestion that con= vert error_report() >> in the function called by net_socket_*_init() to Error. Al= so add many error >> handling information. >> * PATCH 03 net_socket_mcast_create(), net_socket_fd_init_dgram() and n= et_socket_fd_init() >> use the function such as fprintf, perror to report an erro= r message. Convert it >> to Error. >> * PATCH 04 parse_host_port() may fail without reporting an error. Now,= fix it to set an >> error when it fails. >> >> Cc: jasowang@redhat.com >> Cc: armbru@redhat.com >> Cc: berrange@redhat.com >> Cc: kraxel@redhat.com >> Cc: pbonzini@redhat.com >> Cc: eblake@redhat.com >> >> Mao Zhongyi (4): >> net/socket: Don't treat odd socket type as SOCK_STREAM >> net/socket: Convert several helper functions to Error >> net/net: Convert parse_host_port() to Error >> net/socket: Improve -net socket error reporting >> >> include/qemu/sockets.h | 3 +- >> net/net.c | 22 +++++-- >> net/socket.c | 153 ++++++++++++++++++++++++++++-----------= ---------- >> 3 files changed, 106 insertions(+), 72 deletions(-)